From: Pierluigi Vicinanza <pierluigi.vicinanza_at_gmail.com>
Date: Wed, 1 Oct 2014 11:23:23 +0100

On 1 October 2014 08:58, Marcin Bukat wrote:
> You should commit to gerrit. Flyspray is for bugs only. Putting all files
in subdir ${ROCKBOX_DIR}/apps/plugins/xrick is the way to go.

Sounds good. Just to be sure, should I do one big commit with plain files
with no history? Should I go via the subtree merge route?
If I'll use subtre merge, how will gerrit cope with that? Will it be
spammed with tons of separate commits from previous history?

> My experience is that the biggest hassle is to create keymaps for various
targets. With proper defines everything should work out of the box. So if
this would be possible to use PLA this would be BIG win.

I guess you mean pluginlib actions here? I think I'm already using them,
all you have to do is to test/add keymaps for your target to this file:
https://github.com/pierluigi-vicinanza/xrick/blob/master/source/xrick/system/rockboxcodes.h

Moreover, once we'll have a list of compatible targets, we should be able
to tweak "${ROCKBOX_DIR}/apps/plugins/SUBDIRS" accordingly I guess.


On 1 October 2014 09:54, Frank Gevaerts wrote:
> I'm assuming the files are freely redistributable at least here.

If you are talking about source files, then yes: game engine has been
released "as is" by the original xrick author (and hence me), and I've put
usual Rockbox header comments in rockbox specific files.
Unfortunately with resource files is a different story, no one knows who
owns the rights, as mentioned by Rick Dangerous creator here:
http://www.simonphipps.com/design/rickdangerous.htm

>There are two options, I think. Either they're hosted on rockbox.org (talk
to
> Björn (Zagor on irc) about whether this is an option, I don't know if
> there are issues with hosting non-free data there), or you keep them on
> e.g. your github space.

No problem in letting people download data files from my github. Actually
for now I think this might be a better solution e.g. in case I make further
changes to file format/add features etc.
In future you might want to host a copy on rockbox.org regardless once
development stabilizes.

> In any case, it would probably be useful if you
> also talk to the Rockbox Utility people about installing these files.

Will do.

Thanks a lot guys.

Piero
Received on 2014-10-01