Rockbox mail archiveSubject: Re: Revert "Rewrite filesystem code (WIP)"
Re: Revert "Rewrite filesystem code (WIP)"
From: Andrey Ryabinin <ryabinin.a.a_at_gmail.com>
Date: Sat, 29 Nov 2014 15:20:45 +0400
2014-11-29 13:45 GMT+03:00 Thomas Martitz <kugel_at_rockbox.org>:
> I tend to agree. I think it also broke the Samsung ypr0/yrp1 targets (though
> the fix for those might be trivial). But the commit message doesn't read
> like it would give anything essential/substantial enough to warrant breaking
> a whole class of targets.
> That said, my guess is that the root cause for the rk27xx is probably
> somewhere in the interaction with the hardware dependent code. It would be
> nice if that was found and the filesystem commit could stay (or be
> re-applied) because it does bring some benefits.
I think we should start from reverting and then reapplying it back but
in small (relatively)
separte commits. pamaury already volunteered to help me with that.
This will help us to understand what part of this change caused problems,
and it also could help in bisecting any future problems that may arise
because of this revwrite.
> But yea, revert if it breaks a lot of targets that otherwise have no working
> Best regards.
-- Best regards, Andrey RyabininReceived on 2014-11-29