Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: buflib handling in picture flow plugin

Re: buflib handling in picture flow plugin

From: Thomas Jarosch <tomj_at_simonv.com>
Date: Sun, 22 Feb 2015 21:47:08 +0100

Am Sonntag, 22. Februar 2015, 21:31:14 schrieb Thomas Martitz:
> > thanks for the review. I noticed the same thing a few days after
> > committing it. It occupied my mind why it wasn't crashing before ;)
> > Do you think we should revert it or keep it? It won't hurt I guess.
> >
> > Did you have a chance to look at the other buflib changes I did?
> > They should be correct IMHO.
>
> IMO, yes, it should be reverted, because adds unecessary overhead and
> gives the false impression that callbacks are always required.
>
> I didn't notice other problems with your buflib related commits but I
> maybe missed some. Do you want me to look at a particular change?

alright, I'll revert it the next days.

Everything is fine with the other commits from my point of view.

Cheers,
Thomas
Received on 2015-02-22


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa