dev builds
themes manual
device status forums
mailing lists
IRC bugs
dev guide

Recent activity


Today 12:19 287747591e: plugins: vbrfix: Fix fd leak & error handling

- mp3info returns true for error
- fd wasn't closed for non-vbr files
apps/plugins/vbrfix.c [diff]
Christian Soffke
Thursday 05:04 2456d28e21: [BugFix] open_plugin didn't recognize opx shortcuts

opx shortcuts allow an easy way to add parameters to plugins you should be able to set them as shortcuts now

the plugin hd a use after free bug on the dat file file descriptor
apps/open_plugin.c [diff]
apps/plugins/open_plugins.c [diff]
William Wilgus
25th Mar 14:02 a2e5d9563f: [Feature] resume TSR plugins after interruption WIP

save tsr plugin path for later

resume tsr plugin when user stops the interrupting plugin

expand return of tsr_exit function to allow continue, suspend, terminate

tsr plugins check parameter at start to determine if the plugin is being resumed
apps/plugin.c [diff]
apps/plugin.h [diff]
apps/plugins/announce_status.c [diff]
apps/plugins/battery_bench.c [diff]
apps/plugins/lastfm_scrobbler.c [diff]
apps/plugins/test_usb.c [diff]
William Wilgus
24th Mar 19:02 2e99e2175b: playlist: Remove control file cache

Control cache entries cost 24 bytes per command, but cacheable commands are always less than that when written out to the file. We can actually cache *more* data by writing commands directly to the fd (native Rockbox has a 512-byte cache per fd) and it's much simpler.
apps/playlist.c [diff]
apps/playlist.h [diff]
Aidan MacDonald
24th Mar 19:02 a4cfa8ae6a: playlist: Unconditionally strip bogus dirs in playlist_peek()

The intent behind the check is to only do this if the filename comes from an on-disk file. With the RAM buffer is gone this is now "always" the case.
apps/playlist.c [diff]
Aidan MacDonald
24th Mar 19:02 aab6a44fc5: filetree: Remove dead code in ft_build_playlist()

This checks for an out of memory condition when the filenames were buffered in RAM. The playlist no longer buffers anything in RAM so the code is unreachable.
apps/filetree.c [diff]
Aidan MacDonald
24th Mar 11:10 1f1893f520: playlist: Remove in-ram filename storage

Use the playlist control file for directory playback instead of storing filenames in RAM. The implementation of that feature is very iffy and probably responsible for random crashes that may occur when skipping through directories rapidly.
apps/playlist.c [diff]
apps/playlist.h [diff]
Aidan MacDonald
24th Mar 11:10 ac1cbd5dd0: playlist: Clean up close_playlist_control_file()

Move locking outside the function since most callers already hold the lock.
apps/playlist.c [diff]
Aidan MacDonald
24th Mar 10:36 e6534b051e: playlist: Add helpers for opening/closing .m3u playlist

This helps maintainability and ensures the opening is done consistently.
apps/playlist.c [diff]
Aidan MacDonald
24th Mar 10:12 5eb24a9582: playlist: Cleanup get_next_dir()

Pass the direction as a signed integer to avoid jumping through unnecessary hoops.
apps/playlist.c [diff]
Aidan MacDonald
23rd Mar 18:16 58b2e45782: Fix unified syntax in ARM inline assembly

GCC 4.9 always emits assembly with divided syntax. Setting unified syntax in inline assembly causes the assembler to complain about GCC's generated code, because the directive extends past the scope of the inline asm. Fix this by setting divided mode at the end of the inline assembly block.

The assembler directives are hidden behind macros because later versions of GCC won't need this workaround: they can be told to use the unified syntax with -masm-syntax-unified.
apps/plugins/mpegplayer/mpeg_misc.h [diff]
firmware/asm/arm/corelock.c [diff]
firmware/asm/arm/thread.c [diff]
firmware/export/config.h [diff]
firmware/target/arm/pcm-telechips.c [diff]
firmware/target/arm/pp/pcm-pp.c [diff]
lib/rbcodec/codecs/demac/libdemac/vector_math16_armv6.h [diff]
Aidan MacDonald
23rd Mar 17:28 86429dbf1e: Using ARM Unified Assembler Language
apps/plugins/mpegplayer/libmpeg2/idct_arm.S [diff]
apps/plugins/mpegplayer/libmpeg2/idct_armv6.S [diff]
apps/plugins/mpegplayer/mpeg_misc.h [diff]
apps/recorder/jpeg_idct_arm.S [diff]
firmware/asm/arm/corelock.c [diff]
firmware/asm/arm/lcd-as-memframe.S [diff]
firmware/asm/arm/memcpy.S [diff]
firmware/asm/arm/memmove.S [diff]
firmware/asm/arm/memset.S [diff]
firmware/asm/arm/memset16.S [diff]
firmware/asm/arm/thread.c [diff]
firmware/export/config.h [diff]
firmware/target/arm/ata-as-arm.S [diff]
firmware/target/arm/ipod/video/lcd-as-video.S [diff]
firmware/target/arm/pcm-telechips.c [diff]
firmware/target/arm/pp/pcm-pp.c [diff]
lib/arm_support/support-arm.S [diff]
lib/rbcodec/codecs/demac/libdemac/udiv32_arm.S [diff]
lib/rbcodec/codecs/demac/libdemac/vector_math16_armv6.h [diff]
lib/rbcodec/codecs/libtta/filter_arm.S [diff]
lib/rbcodec/dsp/dsp_arm.S [diff]
lib/rbcodec/dsp/dsp_arm_v6.S [diff]
lib/unwarminder/safe_read.S [diff]
Chris Chua
23rd Mar 17:01 a64cad847e: playlist: Simplify playlist modified detection

Any modifications to the playlist (insert, delete, shuffle, etc) will cause the modified flag to be set. The flag is cleared when the playlist is saved. Code that generates playlists can manually clear the modified flag if appropriate; there is now a proper API for this so the tagcache and pictureflow don't need to resort to hacks.
apps/playlist.c [diff]
apps/playlist.h [diff]
apps/playlist_viewer.c [diff]
apps/plugin.c [diff]
apps/plugin.h [diff]
apps/plugins/pictureflow/pictureflow.c [diff]
apps/tagtree.c [diff]
Aidan MacDonald
21st Mar 20:23 d40a598970: plugins: Simplify plugin/codec API versioning

Replace the minimum version bound with a check on the size of the API struct. The version only needs to be incremented for ABI breaking changes. Additions to the API won't need to touch the version number, resulting in fewer merge conflicts.
apps/codecs.c [diff]
apps/plugin.c [diff]
apps/plugin.h [diff]
apps/plugins/imageviewer/image_decoder.c [diff]
apps/plugins/imageviewer/imageviewer.h [diff]
apps/plugins/lib/overlay.c [diff]
lib/rbcodec/codecs/codecs.h [diff]
Aidan MacDonald
21st Mar 09:31 2fb2364686: makefiles: Fix escaping issues under GNU make 4.2

Make 4.3 and newer doesn't interpret comments in a shell call, whereas Make 4.2 and older do. Escaping the comment directly works on old makes, but on new makes the backslash is passed as well -- which we want to avoid.

The safe way to pass a literal "#" character to the shell on both versions is by embedding it in a variable and expanding that. It's ugly, but it works...
tools/functions.make [diff]
Aidan MacDonald
All commits since last release, last four weeks.


19th Mar 18:05AIGOErosQKDanaConrad


Recent Threads on the Mailing Lists
when what who
Today 11:39Rockbox on an ESP32? Solomon Peachy via rockbox
26th Mar 17:30Downtime due to upcoming server host migration on 2023-03-26 Solomon Peachy via rockbox
20th Mar 13:22agptek U3 Solomon Peachy via rockbox
18th Mar 18:23rockbox, 64GB SDXC card and win10 format fat32 David Mehler via rockbox
2022-05-17Rbutil 1.5.1 voice creations problem. Matej Golian via rockbox
2022-01-11Talking plugings E. Röder via rockbox
2022-01-01last minute fosshost VM migration 2022-01-01 Solomon Peachy via rockbox
2021-12-20Help for Iriver H340 bricked. Alessio Lenzi via rockbox
2021-12-07Rockbox ipod not recognized by windows 10 John Abrams via rockbox
2021-12-06Recommendations for a new player Laz via rockbox
2021-11-20SMAF support for MIDI Eric via rockbox-dev
2021-10-15iPod Video 5th Gen - Rebooting into Apple firmware David Greenfield via rockbox
2021-10-09Website reliability Solomon Peachy via rockbox migrating Sep 26 _at_12pm US Eastern Sam Kuper via rockbox
2021-09-21Help please with Sansa Clip+ Wilgus William via rockbox
2021-09-17Rockbox forums migrating Sep 19 _at_ 12:00 US Eastern Solomon Peachy via rockbox migrated, git + gerrit next Solomon Peachy via rockbox
2021-09-05hosting update: dns & existing email aliases Solomon Peachy via rockbox
2021-09-03xDuoo Nano D3 fenugrec via rockbox
2021-08-31Update on rockbox hosting (major changes are coming) Solomon Peachy via rockbox

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy