dev builds
themes manual
device status forums
mailing lists
IRC bugs
dev guide

Recent activity


Today 16:13 756c0d2ac8: FS #13299: Simplify VBR frame parsing in the metadata decoder.

The old code would seek forward by the frame length, expecting to see a frame header there, perform a validity check, and then seek back to the current header.

Unfortunately this doesn't handle situations where there is extra padding between the frames, leading us to potentially read garbage, causing the validity tests to fail and rejecting the file outright.

Instead, keep track of the previous valid header/position, and if we find
"valid" headers in a row return the first after seeking back to it.

This change allows the file referenced in FS13299 to be properly parsed, but further work is needed to get the file to be playable. (file reports itself as layer 1, variable bit rate, variable sample rate!)
lib/rbcodec/metadata/mp3data.c [diff]
Solomon Peachy
Yesterday 21:11 c067b344e8: FS #13297: M3K Autolock allows one action before disabling touchpad

Intercept buttonpress and action, and nullify both if the button is part of the touchpad. Only affects autolock functionality.

Adding removal of note about autolock in the manual - the lock button no longer needs to be pressed at least once to prime the autolock, if enabled, since commit 14f7a95
apps/action.c [diff]
manual/configure_rockbox/system_options.tex [diff]
Dana Conrad
Yesterday 14:47 f3f9d1fb95: USB Serial: Implement Abstract Control Management

On devices that can assign interrupt IN, bulk IN and bulk OUT endpoints this change results in the serial interface working out of the box on Linux and Windows. On Linux it is registered as ttyACM device and on Windows it is assigned a COM port number.

On devices that cannot assign the interrupt IN this change won't have any effect.

Implement minimum required interface control requests. Respond with whatever line coding was set to make terminal programs happy.
firmware/export/usb_ch9.h [diff]
firmware/usbstack/usb_serial.c [diff]
Tomasz Moń
Yesterday 13:54 663d846cf3: Sansa Connect: Disable endpoint double buffering

Disabling double buffering results in expected CPPI TX behaviour. With the double buffering enabled, sending single ZLP resulted in two ZLPs being available. The two ZLPs is problematic because this causes Windows to reset USB device after failed SCSI command.

The problematic sequence on Windows 10 was as follows:
* Host sends SCSI Mode Sense(6) Informational Exceptions Control(0x1C)
* Device sends ZLP
* Device sends command failed response

With endpoint double buffering enabled the ZLP was read twice by host. As host was expecting command response on the second read (and got ZLP instead), host attempts recovery by resetting USB device and retrying.
firmware/target/arm/tms320dm320/sansa-connect/tnetv105_usb_drv.c [diff]
Tomasz Moń
Yesterday 06:32 a90ef8195b: mknkboot/beastpatcher: implement basic firmware validation

This imports the MD5 code used by other utilities and creates a function for checking the provided NK.bin against known original firmware checksums. Integration into mknkboot and beastpatcher is also added.

For the sake of consistency with beastpatcher, mknkboot had its printf statements rewrote to print to stderr like beastpatcher does.
utils/MTP/beastpatcher/Makefile [diff]
utils/MTP/beastpatcher/beastpatcher.c [diff]
utils/MTP/beastpatcher/md5.c [new]
utils/MTP/beastpatcher/md5.h [new]
utils/MTP/beastpatcher/mknkboot.c [diff]
utils/MTP/beastpatcher/mknkboot.h [diff]
James Buren
Friday 19:32 fe9bcd0468: beastpatcher: fix some minor issues

This mainly fixes some compiler warnings and makes it work with mingw64.
utils/MTP/beastpatcher/Makefile [diff]
utils/MTP/beastpatcher/mtp_libmtp.c [diff]
James Buren
Friday 19:32 ab0f23c4b1: sendfirm: fix some minor issues

This patches some compile warnings and also makes it work correctly with modern mingw64.
utils/MTP/Makefile [diff]
utils/MTP/sendfirm.c [diff]
James Buren
Friday 19:09 d01f3192f2: Spin off common ft6x06 code to a driver

Allows for the i2c boilerplate to be shared between the M3K and Shanling Q1 ports. M3K-specific quirks remain in button-fiiom3k.
firmware/SOURCES [diff]
firmware/drivers/ft6x06.c [new]
firmware/export/config/fiiom3k.h [diff]
firmware/export/ft6x06.h [new]
firmware/target/mips/ingenic_x1000/fiiom3k/button-fiiom3k.c [diff]
Aidan MacDonald
Thursday 06:43 551c74da55: Sansa Connect: Remove fake battery voltage scale

Use battery percentage as reported by AVR.
firmware/SOURCES [diff]
firmware/export/config/sansaconnect.h [diff]
firmware/target/arm/tms320dm320/sansa-connect/avr-sansaconnect.c [diff]
firmware/target/arm/tms320dm320/sansa-connect/powermgmt-sansaconnect.c [deleted]
Tomasz Moń
Thursday 06:02 f26499bd67: Sansa Connect: Add missing include

Include usb.h to have usb_acknowledge() prototype.
firmware/target/arm/tms320dm320/sansa-connect/avr-sansaconnect.c [diff]
Tomasz Moń
Wednesday 18:52 163e3507f8: Sansa Connect: Working USB Mass Storage

Acknowledge SYS_USB_CONNECTED in all queues so USB task can gain exclusive access to the storage.

Reduce CPPI requeue timeout to speed up disk access.
bootloader/sansaconnect.c [diff]
firmware/export/config.h [diff]
firmware/target/arm/tms320dm320/sansa-connect/avr-sansaconnect.c [diff]
firmware/target/arm/tms320dm320/sansa-connect/tnetv105_usb_drv.c [diff]
firmware/target/arm/tms320dm320/sdmmc-dm320.c [diff]
Tomasz Moń
Wednesday 17:13 a11c88e0df: Sansa Connect: Fix sending ZLP on non-zero endpoint

This fixes panic when mass storage driver sends failed result.
firmware/target/arm/tms320dm320/sansa-connect/tnetv105_usb_drv.c [diff]
Tomasz Moń
Wednesday 10:21 efa173a923: Sansa Connect: Fix bulk transfers greater than 64 bytes

Correctly set endpoint maximum packet size so host will not consider end of transfer after receiving first packet when transfer is larger than 64 bytes (at High Speed the endpoint max packet size was set to 64 but according to descriptor it is 512).

Split DMA transfers up to CPPI_MAX_FRAG so we get single interrupt after each call to tnetv_cppi_send().
firmware/target/arm/tms320dm320/sansa-connect/tnetv105_usb_drv.c [diff]
Tomasz Moń
Wednesday 10:09 7f3d0ce814: DM320: Fix SDHC response format 2 handling

Return complete R2 response to caller. Due to incorrect bitfield handling only bits [127-96] were ever returned to caller.
firmware/target/arm/tms320dm320/sdmmc-dm320.c [diff]
Tomasz Moń
7th Jun 22:01 41ced369f6: ErosQ Simulator: fix keymap

The eros q simulator keys have been weird for a while, found out why.
uisimulator/buttonmap/erosq.c [diff]
Dana Conrad
All commits since last release, last four weeks.


Yesterday 14:52SansaConnectTomaszMon
6th Jun 11:59ShanlingQ1PortAidanMacDonald
23rd May 14:36RockboxUtilityDominikRiebeling
20th May 00:01ArchosFAQRobertMenes
19th May 23:44ArchosAv300PortRobertMenes
17th May 14:21FiioM3KAidanMacDonald


Recent Threads on the Mailing Lists
when what who
28th May 13:45Setting Date and Time on Xduoo X3 II? Matej Golian via rockbox
25th May 10:01Is Rockbox currently unable to support micro SD card readers on Dx50/90? Sascha Lüdecke via rockbox
24th May 13:05Grouping Album Tracks In The Database By Codec Or File Extension? Matej Golian via rockbox
23rd May 13:57Rockbox IRC channels migrated to Libera Solomon Peachy via rockbox
21st May 14:45Rockbox trademark? Solomon Peachy via rockbox-dev
21st May 01:31First time user: *PANIC* when trying to play any file eoo––– via rockbox
16th May 09:48Possible Playlist/voice bug; should I put this in the tracker or is there a work-around? Holden McFarland via rockbox
15th May 12:14Dx 50/90; possibility to enable dac/amp support on computer Holden McFarland via rockbox
14th May 01:47Ibasso DX 90 issues resolved but a few more questions and suggestions Solomon Peachy via rockbox
14th May 01:32DX50 now works, was installing original firmware when I thought it was modified Solomon Peachy via rockbox
12th May 21:24DX50; can anyone tell me what I'm missing in this update process Holden McFarland via rockbox
6th May 00:22Updates on our gerrit instance Solomon Peachy via rockbox-dev
28th Apr 09:47Speech support, specifically in regard to Dx50/dx90 Holden McFarland via rockbox
17th Apr 22:50xDuoo X3ii boot menu timeout Patrice Levesque via rockbox
14th Apr 11:40rockbox Digest, Vol 173, Issue 3 Alex Claessens via rockbox
13th Apr 16:41rockbox on x3 current build not speaking everything Solomon Peachy via rockbox
9th Apr 21:30PPA for Rockbox works with Ubuntu 20.04 Benjamin Balder Bach via rockbox
7th Apr 13:55New update to italian translation. Alessio Lenzi via rockbox-dev
6th Apr 11:06info-mp3-xduoo x3ii-eror-failed-reading-voice Solomon Peachy via rockbox
19th Mar 22:08Ode to Rockbox :) Vladimir Pantelic via rockbox-dev

Page was last modified "Mon Nov 16 10:57:21 2020" The Rockbox Crew -- Privacy Policy