dev builds
themes manual
device status forums
mailing lists
IRC bugs
dev guide

Today 01:17 bd339dabac: FS #13993: Updated Polish translation (Adam Rak)
apps/lang/polski.lang [diff]
Solomon Peachy
Today 01:17 412e0621c1: Update english-us "translation"
apps/lang/english-us.lang [diff]
Solomon Peachy
27th May 23:17 3ef49d9c5e: PictureFlow: Make Shuffle options available

The "Playing Next..." menu couldn't display any options for shuffling tracks of an album before
apps/onplay.c [diff]
apps/onplay.h [diff]
apps/playlist_viewer.c [diff]
apps/plugin.h [diff]
apps/plugins/pictureflow/pictureflow.c [diff]
apps/shortcuts.c [diff]
Christian Soffke
26th May 17:13 028eafaeef: Onplay: Fix items from Queue submenu appearing at top level

If "Show Queue Options" was set to "in Submenu", the queue options would incorrectly appear at the top level after you had queued a track, at least until you entered and exited the submenu again without selecting an option.
apps/onplay.c [diff]
Christian Soffke
26th May 17:08 31b8cd8f73: PictureFlow: Remove menu items for "Return" and "Clear Playlist"

On all players, it should be possible to return from the Main Menu by pressing the Back or Menu key. Unless I'm missing something...

"Clear Playlist" has hopefully become superfluous after the "Playing Next" context menu was added, which offers similar functionality.
apps/lang/english.lang [diff]
apps/plugins/pictureflow/pictureflow.c [diff]
manual/plugins/pictureflow.tex [diff]
Christian Soffke
26th May 16:48 6e192dc28d: hiby: the second drive for these is "USB" not "HD1"
apps/lang/english.lang [diff]
Solomon Peachy
26th May 16:29 49b877470d: PictureFlow: Add ability to go to last album

After launch, PictureFlow always goes to the currently playing album, or to a selected album, if applicable. Which is probably a useful default, but not always wanted. You can now get back to the album you were looking at when PictureFlow was last closed, or when the sorting was last changed.
apps/lang/english.lang [diff]
apps/plugins/pictureflow/pictureflow.c [diff]
manual/plugins/pictureflow.tex [diff]
Christian Soffke
26th May 16:26 bbef598817: PictureFlow: Scroll through albums from track list

This lets players that can't spare any keys scroll through albums without leaving the track listing first, which was only possible on the M3K before.

Enter mode from Main Menu. While active, the gradient highlighting an album's selected track will not appear, and context menu options apply to the whole album instead of to a single track.

Exit mode by pressing buttons for Select/Back, or by quitting PictureFlow.

NB: Be sure to enable "Database in RAM" for a good experience, as the loading time for each album can become quite annoying otherwise.
apps/lang/english.lang [diff]
apps/plugins/pictureflow/pictureflow.c [diff]
manual/plugins/pictureflow.tex [diff]
Christian Soffke
25th May 20:27 0f941488af: dbtool: Fix red.

Apparently _most_ targets have a dbtool built as a simulator variant, but _some_ are built as an application target. This commit fixes simulator-based targets, which weren't ever broken.

(Prior commits fixed things for _app_ targets, which haven't worked since at least 2020, maybe never..)
tools/database/database.c [diff]
Solomon Peachy
25th May 20:05 8bc7ba5d22: dbtool: More fixes to dbtool operation

Now properly treats current directory as "/"
firmware/target/hosted/filesystem-app.c [diff]
tools/configure [diff]
tools/database/database.c [diff]
Solomon Peachy
25th May 19:43 e803daae0a: dbtool: Fix it up so that it runs from the CURRENT working directory

This makes it far more useful, as before it insisted on scanning from the root directory and putting the generated db files in /.rockbox
tools/configure [diff]
tools/database/database.c [diff]
Solomon Peachy
25th May 16:47 11e858b209: fix yellow introduced in previous commit
firmware/target/hosted/filesystem-app.c [diff]
Solomon Peachy
25th May 16:13 220fb04250: hosted: Fix the disk storage display in the rockbox info page

This was introduced by adding multivolume support to the hibyplayer units, and might affect other things, if so a more general fix might be needed.
firmware/target/hosted/filesystem-app.c [diff]
Solomon Peachy
24th May 17:23 f2a5b78b51: Sansa Clip keymap: Playlist on short Down press and Hotkey on long Down press in WPS
apps/keymaps/keymap-clip.c [diff]
manual/platform/keymap-sansaclip.tex [diff]
23rd May 19:57 3acd5f86e5: build: Fix problems compiling old glibc with gmake >= 4.4

Three separate problems:

1) Make 4.4 defaults to a named pipe for jobserver control, this was incompatible with how glibc did recursive makes 2) Make 4.4 passed long arguments ( --foo ) into MAKEFLAGS and this broke stuff that wasn't expecting it 3) Circular dependency in a header generation due do make 4.4 being stricter/more consistent in how it orders rules vs which makefiles they came from. This one was the real !@#!@ to deal with.

This patch set fixes the hosted arm (glibc 2.19) and mips (glibc 2.25) toolchains.
tools/ [diff]
tools/toolchain-patches/glibc-220-make44.patch [new]
tools/toolchain-patches/glibc-225-make44.patch [new]
Solomon Peachy
22nd May 19:58 56fe1129da: configure: Deal with more variations of the 'ld' version output

eg, our current toolchian generates this:

GNU ld (GNU Binutils) 2.26.1

But the system toolchain on the buildserver generates this:

GNU ld version 2.37-37.fc36
tools/configure [diff]
Solomon Peachy
22nd May 18:48 e7cc77e5b8: configure: Detect linker's NO_CROSSREFS_TO() support

NO_CROSSREFS_TO() was first introduced in binutils 2.27. It is used to have the linker report errors when symbols from a list of sections refer to a specified section, which is useful for verifying that normal code does not refer to INIT_ATTR code.

Note this doesn't actually start using NO_CROSSREFS_TO() for builds -- that will have to wait until the toolchain upgrade when we'll have a new enough binutils -- it just detects support for the feature so it can be conditionally enabled in linker scripts.
tools/configure [diff]
Aidan MacDonald
22nd May 14:53 6e05fcf4d0: FS #13551: Correct the native name for the Slovak language (in rbutil)
utils/rbutilqt/rbutil.ini [diff]
Solomon Peachy
22nd May 14:30 92b80bdba5: lang: Support languages that speak the units before a numerical value

Previously, it was hardcoded to the english convention of units-last, so
"100%" would be voiced as "one hundred percent". This adds a new language flag that makes the units be voiced first, ie "100%" will be voiced as "percent one hundred".

So far only the Chinese-traditional and Chinese-simplified languages utilize this feature (taken from an old ticket, FS #10340) but I'm sure others would want this feature too.
apps/lang/chinese-simp.lang [diff]
apps/lang/chinese-trad.lang [diff]
apps/language.c [diff]
apps/language.h [diff]
apps/talk.c [diff]
tools/genlang [diff]
Solomon Peachy
22nd May 14:28 ab0ba139f5: pdbox: Gate the warning suppression to apply only to GCC 13 and newer.
apps/plugins/pdbox/PDa/src/m_obj.c [diff]
Solomon Peachy
22nd May 00:58 3a8d5525ae: pdbox: Fix warning with GCC13
apps/plugins/pdbox/PDa/src/m_obj.c [diff]
Solomon Peachy
22nd May 00:34 5dc0e4e0bc: disk: Support GUID Partition Tables (GPT)


* Currently limited to 32-bit sector addresses due to internal Rockbox APIs. So this means a practical limit of 2TiB per drive.
* Only 'General Data' GPT partition type is recognised, as that's what SD cards seem to use for exFAT/FAT32.

Note that _booting_ off GPT-partitioned drive will require rebuilding the various rockbox bootloaders, and even then there may be platform limitations that preclude this.
firmware/common/disk.c [diff]
firmware/export/disk.h [diff]
Solomon Peachy
21st May 02:41 8fbd44a3d3: [BugFix] Last Fm Scrobbler corrupted entries

I couldn't seem to reproduce the issue here:,54165.msg252081.html#msg252081

but I figure its probably a threading issue

so we now have a mutex on the cache

and to top it all off each cached entry has a crc and length that are checked before writing the entry to the file otherwise it is prepended with # FAILED - so hopefully scrobbler 'parsers?' don't barf on the log

Other changes: there is now a MRU table for tracks this should help prevent duplicates it is configurable..

the cache buffer now no longer uses fixed chunks allowing more tracks to be written between flushes
apps/plugins/lastfm_scrobbler.c [diff]
William Wilgus
17th May 17:23 4554b90859: sdl: fix two bugs in ROCKBOXAUD_PlayAudio()

First was an off-by-one bug in the loop over buffers. The condition was
`i < this->hidden->n_buffers', but should have been <=, not <. This wasn't a critical issue, because the last iteration would check the currently playing buffer - an unlikely situation.

The second logic bug would make the code always think it had found an empty buffer, even when it had not, since `idx' was being unconditionally set every loop, rendering it unusable for a sentinel value. Fix that.
apps/plugins/sdl/src/audio/rockbox/SDL_rockboxaudio.c [diff]
Franklin Wei
17th May 17:19 e232f69214: atjboottool: gzipped fw files, option for big-endian fw, clarify ECIES in fwu

Added fw modifications required to unpack real world player dumps.

Documented more fwu header fields, magic numbers and finite field arithmetics (extended Euclidean for inverse, long division for reducing modulo field_poly).

v3 encryption used is standard RC4 with the key additionally ciphered by the Elliptic Curve Integrated Encryption Scheme.

Either sect233k1 (NIST K-233) or sect163r2 (NIST B-163) curves can be used, with the former overwhelmingly prevailing, being hardwired in SDK's maker.exe. Using a private/public key scheme is superfluous because both are stored in the firmware, with the added level of complexity likely serving the purpose of obfuscation. The private key is generated at random with each invokation.

None of KDF or MAC from ECIES are used, RC4 key is directly xored with the shared secret. The random number r used to calculate rG isn't stored, but that's unimportant since only krG == rkG is actually used in the encryption.
utils/atj2137/atjboottool/Makefile [diff]
utils/atj2137/atjboottool/atj_tables.c [diff]
utils/atj2137/atjboottool/atj_tables.h [diff]
utils/atj2137/atjboottool/atjboottool.c [diff]
utils/atj2137/atjboottool/fw.c [diff]
utils/atj2137/atjboottool/fw.h [diff]
utils/atj2137/atjboottool/fwu.c [diff]
Nikita Burnashev
17th May 15:55 72c0e49b41: scroll: Fix red from previous commit.

Targets with remote LCDs need to have the lcd scroll driver instantiated, even in the bootloader.

This is because lcd_remote_scroll_stop() is called, in addition to lcd_scroll_stop(). This could probably be excised.
firmware/drivers/lcd-scroll.c [diff]
firmware/scroll_engine.c [diff]
Solomon Peachy
17th May 15:03 9134c688d9: scroll: Eliminate a warning when building a bootloader

Bootloaders don't support scrolling, so don't even try to compile the scroll_thread stuff
firmware/scroll_engine.c [diff]
Solomon Peachy
9th May 20:37 fdf661606c: FS #13992: Update Serbian translation (Ivan Pesic)
apps/lang/srpski.lang [diff]
Solomon Peachy

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy