dev builds
themes manual
device status forums
mailing lists
IRC bugs
dev guide

Thursday 07:57 7a132a2: Fix playback.c audio_track_count() warning

changes return to unsigned int to match underlying aliased function
apps/debug_menu.c [diff]
apps/playback.c [diff]
apps/playback.h [diff]
William Wilgus
Thursday 06:03 7c2295e: Diacritic.c add newline to EOF
firmware/common/diacritic.c [diff]
William Wilgus
2017-11-09 b977b77: Optimize is_diacritic

is_diacritic is used for pretty much all of the text display sizing Timing here matters, so important it uses a priority buffer in order to cut down on searching the database.

This patch is verified functionally equlivalent but saves 80 bytes and is ~20% faster for the clip+ I tested it on

Several things were done:

Optimizing the copy loop for the priority buffer

Globbing some operations together

but the main one has to do with the database structure its self
-- Rather than a bit packed struct it combines the lower 8 bytes into one value [info] and uses flags to access the values instead
firmware/common/diacritic.c [diff]
William Wilgus
Monday 21:04 dd40c46: Fix menu warnings

change offending bool return to int

warning: cast between incompatible function types from
'_Bool (*)(void)' to 'int (*)(void)' [-Wcast-function-type]

forgot to remove -- typedef int (*menu_function)(void);
apps/alarm_menu.c [diff]
apps/alarm_menu.h [diff]
apps/debug_menu.c [diff]
apps/debug_menu.h [diff]
apps/enc_config.c [diff]
apps/enc_config.h [diff]
apps/menu.h [diff]
apps/menus/eq_menu.c [diff]
apps/menus/eq_menu.h [diff]
apps/menus/main_menu.c [diff]
apps/menus/playlist_menu.c [diff]
apps/menus/radio_menu.c [diff]
apps/menus/recording_menu.c [diff]
apps/menus/settings_menu.c [diff]
apps/menus/time_menu.c [diff]
apps/screens.c [diff]
apps/screens.h [diff]
apps/settings.c [diff]
apps/sound_menu.h [diff]
apps/tagtree.c [diff]
apps/tagtree.h [diff]
apps/tree.c [diff]
apps/tree.h [diff]
William Wilgus
15th Oct 12:25 e6b23a8: onda: fix compiler warning in boot loader
bootloader/ondavx747.c [diff]
Solomon Peachy
13th Oct 11:35 07fed90: lua optimize current_path function

frees up around 500 bytes by using the builtin string functionality
apps/plugins/lua/loadlib.c [diff]
apps/plugins/lua/rockaux.c [diff]
apps/plugins/lua/rocklib.c [diff]
apps/plugins/lua/rocklib.h [diff]
William Wilgus
12th Oct 09:58 0b7a8d5: Lua remove unusable/unneeded functions from rocklib_aux

rocklib_aux is auto generated from plugin.h there are a few functions that get added automatically that are unusable without their companion functions or duplicate functionality already supplied by lua

Duplicated functionality: rb->rand, rb->srand
-- see math.rand math.srand

rb->remove, rb->rename
-- see os.remove, os.rename

Unusable: rb->open_utf8
-- this should be added to the lua file open routines (if at all)

rb->codec_run_proc, rb->codec_close
-- without rb->codec_load_file these are pointless

rb->timer_set_period, timer_unregister
-- even with timer_register implemented lua is not
-- reentrant and crashes the state when timer fires

Shouldn't be used!: rb->strlcpy, rb->strlcat, rb->strcpy, rb->strcat
-- lua reuses strings by hashed values you break this contract if
-- you change strings behind its back plus lua provides a way to
-- do these functions safely within the strings api
apps/plugins/lua/ [diff]
William Wilgus
9th Oct 20:29 d2cef81: mips: fix some compile warnings.
apps/plugins/mpegplayer/video_out_rockbox.c [diff]
firmware/target/mips/ingenic_jz47xx/ata-nand-jz4740.c [diff]
firmware/target/mips/ingenic_jz47xx/ata-nand-jz4760.c [diff]
firmware/target/mips/ingenic_jz47xx/onda_vx747/sadc-onda_vx747.c [diff]
firmware/target/mips/ingenic_jz47xx/onda_vx767/sadc-onda_vx767.c [diff]
Solomon Peachy
9th Oct 12:24 53d72a8: fix builds broken by the selective stack bump for opus seeking.
apps/codec_thread.c [diff]
Solomon Peachy
9th Oct 09:36 71abdf5: mips: jz4740: JZ4740 does not have a MSC clock source select.
firmware/target/mips/ingenic_jz47xx/ata-sd-jz4740.c [diff]
Solomon Peachy
8th Oct 17:52 046cc49: Fix red rocklib_img 32-24 bit targets

int is an incompatible type for targets that have 32bit fb_data need to use FB_SCALARPACK for them
apps/plugins/lua/include_lua/color.lua [diff]
apps/plugins/lua/include_lua/draw.lua [diff]
apps/plugins/lua/include_lua/lcd.lua [diff]
apps/plugins/lua/include_lua/print.lua [diff]
apps/plugins/lua/rocklib_img.c [diff]
William Wilgus
23rd Sep 16:25 c0682e0: Clean up rocklib_img

optimize both size and speed fix invert for color screens
apps/plugins/lua/include_lua/blit.lua [diff]
apps/plugins/lua/include_lua/color.lua [diff]
apps/plugins/lua/include_lua/draw.lua [diff]
apps/plugins/lua/include_lua/image.lua [diff]
apps/plugins/lua/include_lua/lcd.lua [diff]
apps/plugins/lua/include_lua/print.lua [diff]
apps/plugins/lua/rocklib_img.c [diff]
William Wilgus
17th Sep 17:28 e4b8433: lua rocklib cleanup

removes tslf allocations from do_menu and gui_syncyesno_run in favor of lua_newuserdata

removes some luaL_opt functions in favor of equivalent lua_to functions

moves some definitions to the rocklib.h file
apps/plugins/lua/rocklib.c [diff]
apps/plugins/lua/rocklib.h [diff]
William Wilgus
31th Aug 11:39 ebaddc6: build: Log the zipfile creation
tools/root.make [diff]
Solomon Peachy
21st Sep 12:27 3e209f3: misc: Fix some assorted compiler warnings
apps/codec_thread.c [diff]
firmware/storage.c [diff]
tools/rbspeex/rbspeexdec.c [diff]
tools/voicefont.c [diff]
Solomon Peachy

Page was last modified "Oct 24 2016" The Rockbox Crew