Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide
translations



whenwhatwherewho
Today 16:28 29f28ad8e6: flac: Implement proper support for 7 channel FLACs

* Allocate buffer for additional channel
* Proper downmixing
lib/rbcodec/codecs/flac.c [diff]
lib/rbcodec/codecs/libffmpegFLAC/decoder.c [diff]
Solomon Peachy
Today 15:05 3aef933348: flac: Bump maximum channel count to 7 (FS #13306)

This is actually the root fix for the crash; the fix in 772eff8ca6 didn't restrict it to 2 channels, just sanity checked the file vs MAX_CHANNELS.
lib/rbcodec/codecs/libffmpegFLAC/decoder.h [diff]
Solomon Peachy
Today 13:27 ef19fa4408: plugin load / tagtree retrieval: eliminate storage_disk_is_active check

Since commit e0df995 storage_disk_is_active may be 0 even if there is no disk that needs to be spun up or device to power on, so it doesn't really make sense to check for it, anymore, in order to decide whether to display the loading indicator.

For remaining devices with spinning disks, the noise or vibration of the disk spinning up may serve as a sufficient signal when loading a plugin, that the device isn't frozen. Plus, for the tagtree, search progress is displayed after 0.5s anyway.
apps/plugin.c [diff]
apps/tagtree.c [diff]
Christian Soffke
Today 13:19 b8238f7b20: imageviewer: Initial support for JPEG progressive images. Add decoder

Added jpeg decoder jpegp.c using RAINBOW lib. Currently enabled only for pictures not supported by old decoder (as old decoder more optimized for low mem targets)

Someone TODO:
* Old decoder has optimized downscale logic which new decoder doesn't have (it gives big difference in required memory and time for decoding). This logic should be ported/adapted if possible.

* Add smooth downscaling.

* Grayscale support
apps/plugins/CATEGORIES [diff]
apps/plugins/imageviewer/SUBDIRS [diff]
apps/plugins/imageviewer/image_decoder.c [diff]
apps/plugins/imageviewer/image_decoder.h [diff]
apps/plugins/imageviewer/imageviewer.c [diff]
apps/plugins/imageviewer/imageviewer.h [diff]
apps/plugins/imageviewer/jpeg/jpeg.c [diff]
apps/plugins/imageviewer/jpegp/BUFFILEGETC.c [new]
apps/plugins/imageviewer/jpegp/FILEGETC.c [new]
apps/plugins/imageviewer/jpegp/GETC.h [diff]
apps/plugins/imageviewer/jpegp/SOURCES [new]
apps/plugins/imageviewer/jpegp/jpeg81.c [diff]
apps/plugins/imageviewer/jpegp/jpeg81.h [diff]
apps/plugins/imageviewer/jpegp/jpegp.c [new]
apps/plugins/imageviewer/jpegp/jpegp.make [new]
apps/plugins/imageviewer/jpegp/mempool.c [new]
apps/plugins/imageviewer/jpegp/mempool.h [new]
apps/plugins/imageviewer/jpegp/rb_glue.h [new]
manual/plugins/imageviewer.tex [diff]
Roman Artiukhin
Today 13:19 64ad7354b6: imageviewer: Initial support for JPEG progressive images. Add lib sources

Added unmodified files from RAINBOW library by Attila Tarpai Full sources: https://github.com/Halicery/vc_rainbow
apps/plugins/imageviewer/jpegp/GETC.h [new]
apps/plugins/imageviewer/jpegp/idct.c [new]
apps/plugins/imageviewer/jpegp/idct.h [new]
apps/plugins/imageviewer/jpegp/jpeg81.c [new]
apps/plugins/imageviewer/jpegp/jpeg81.h [new]
docs/CREDITS [diff]
Roman Artiukhin
Today 13:00 772eff8ca6: flac: Explicitly reject FLAC files with more than two channels (FS #13306)

It's not clear that we've ever intended to support >2ch files, based on
'#define MAX_CHANNELS 2' and other logic that only seems to care about mono vs not.
lib/rbcodec/codecs/flac.c [diff]
Solomon Peachy
Today 12:56 542eeae11c: configure: Document the '--with-ubsan' argument
tools/configure [diff]
Solomon Peachy
Today 12:56 cda2f90e10: nano2g: Work around GCC9 warning in the FTL code.

As far as I can tell it's a false positive.
firmware/target/arm/s5l8700/ipodnano2g/ftl-nano2g.c [diff]
Solomon Peachy
Yesterday 23:22 d96b222a32: Fix previous commit. don't know how it "worked" for my test build.
tools/configure [diff]
Solomon Peachy
Yesterday 22:52 66ed5232cb: erosq: Change default sysfont to 14-Rockfont-Mix

Former default of 08-Rockbont was borderline illegible on the screen.
tools/configure [diff]
Solomon Peachy
Yesterday 13:33 9420650c87: voice: Normalize all voiced strings NFC form before passing them to TTS engine

This should be a no-op for .lang files, but it can matter when generating talk clips, as those are based on the raw filename.
tools/voice.pl [diff]
Solomon Peachy
Yesterday 13:33 d98cad4301: docs: we use xz, not bz2, for tarballs
docs/README [diff]
Solomon Peachy
Yesterday 09:36 152ec1946c: ipod 4g/color: Fix unresponsive buttons after booting

The iPod 4g and color always ignored the very first button press after booting, i.e. you needed to either press another button or scroll for a bit first.

Not sure whether any other PP iPods exhibit the same behavior, although it is not reproducible on an iPod video.

This patch basically copies the code from FS #5230 that fixed unresponsive buttons whenever the HOLD switch was turned off (committed as a5961c944b).
firmware/target/arm/ipod/button-clickwheel.c [diff]
Christian Soffke
Saturday 20:41 05194ec6eb: voice-corrections: Add " no." -> "number " (English)

This is particularly useful for classical music, where track names like
"symphony no.5" are common -- We want to voice this as "symphony number 5" instead.
tools/voice-corrections.txt [diff]
Solomon Peachy
Saturday 20:41 1694101b23: voice: Also apply voice corrections to talkclips
tools/voice.pl [diff]
Solomon Peachy
Saturday 19:09 38211e627d: AS3525: Get rid of duplicate 'const' in a single definition

(Another GCC9-produced warning)
firmware/target/arm/as3525/system-as3525.c [diff]
Solomon Peachy
Saturday 17:54 6cb0bc3468: coldfire: Silence a warning generated by GCC >= 9

Basically, there are weak aliases for all possible IRQ handlers, pointing at a NORETURN function. GCC complains that the aliases don't have the same attribute, but that's actually what we want.
firmware/target/coldfire/system-coldfire.c [diff]
Solomon Peachy
Saturday 16:26 62d6c7ecaa: pdbox: Silence a spurious warning with GCC9 on hosted ARM

(pdbox seems to trigger a lot of false warnings...)
apps/plugins/pdbox/PDa/src/d_soundfile.c [diff]
Solomon Peachy
Saturday 16:01 d4d74fda00: codecs: abs() --> llabs() in speex and libgme

We were calling abs() on 64-bit (ie long long) variables.
lib/rbcodec/codecs/libgme/ym2612_emu.c [diff]
lib/rbcodec/codecs/speex.c [diff]
Solomon Peachy
Saturday 16:01 8dc42711b4: libc: Correct definition of labs()' and add llabs()
firmware/libc/include/stdlib.h [diff]
Solomon Peachy
Saturday 14:34 e1bed147a3: build: Add advanced option to treat all warnings as errors.
tools/configure [diff]
Solomon Peachy
Saturday 13:23 94d6265df0: gcc9: Move structure packing to the struct definition

Silences GCC9 warnings about possible casting misalignments.
firmware/export/ata.h [diff]
firmware/export/usb_ch9.h [diff]
firmware/usbstack/usb_core.c [diff]
Solomon Peachy
Saturday 02:57 8b9ef7cf8d: sdl: Remove SDL_RENDERER_ACCELERATED flag

The flag would apparently make hardware accelerated rendering mandatory. SDL2 will still attempt to use hardware acceleration, if the flag is missing.
firmware/target/hosted/sdl/system-sdl.c [diff]
Christian Soffke
Saturday 02:56 7d60b13584: pdf50606: Fix questionable code that GCC9 complains about

Instead of:

bool &= ~bool;

do this:

bool &= !bool;
firmware/drivers/rtc/rtc_pcf50606.c [diff]
Solomon Peachy
Friday 17:01 49b6853c19: rockboxdev.sh: bump required version of GMP and MPFR

GMP 4.3.2 was quite old even at the time of the GCC 4.9.4 release, and it refuses to compile out of the box on modern toolchains (eg GCC 14) due to issues in the configure script. Instead of trying to backport fixes, just bump it up to 6.1.2, the final release in the 6.1.x series that was current when GCC 4.9.4 was released.

Meanwhile, with the update to GMP, the also-quite-old MPFR 3.1.0 fails to compile; instead bump it up to 3.1.6, which is the final release in the 3.1.x series.
tools/rockboxdev.sh [diff]
Solomon Peachy
Thursday 14:12 edbcf0b0f4: erosq: Initial PM support for "hw4" variant

(They renamed the battery from 'battery' to 'axp_battery')
firmware/export/config/hibylinux.h [diff]
firmware/target/hosted/aigo/power-erosq.c [diff]
firmware/target/hosted/power-linux.c [diff]
Solomon Peachy
7th Oct 16:36 41abd8e32f: sdlapp: Fix build with SDL2

Not sure why this didn't break in my earlier tests.
apps/playback.c [diff]
Solomon Peachy
7th Oct 16:15 56ec2e2e4a: Only increase sigalthreads stack size for simulator or aarch64 builds.

The 12K-per-thread necessary on arm64 linux systems caused an unnecessary 180K increase in RAM usage on the hibyos hosted ports. So back off to the old size unless we know it was needed.
firmware/asm/thread.h [diff]
Solomon Peachy
7th Oct 16:05 0222ed3639: simulator: Fix SDL2 simulator build of touchscreen-based targets

(cowond2, mrobe500, vx747, shanlingq1, zenxfi2)
firmware/target/hosted/sdl/key_to_touch-sdl.c [diff]
Solomon Peachy
6th Oct 16:05 7927423e34: SDL: Migrate to SDL2

Incorporates large portions of g#5879 g#5282 g#5285 g#5286 g#5287

Differences from the above patches:

* Removed all MacOS-specific stuff
* Removed support for SDL1 entirely
* Properly implement mousewheel support
* Bumped up minimum stack size for sigalstack threading
* Check for overflow before enqueing scrollwheel events

Tested on:

* sdl application (Linux)
* Simulator (x86_64, Linux) -- xduoox3/ipod4g/sansafuze
* Simulator (i686, Windows) -- xduoox3
* Simulator (arm64, Linux)
firmware/asm/thread.h [diff]
firmware/target/hosted/sdl/app/button-application.c [diff]
firmware/target/hosted/sdl/button-sdl.c [diff]
firmware/target/hosted/sdl/kernel-sdl.c [diff]
firmware/target/hosted/sdl/lcd-bitmap.c [diff]
firmware/target/hosted/sdl/lcd-sdl.c [diff]
firmware/target/hosted/sdl/lcd-sdl.h [diff]
firmware/target/hosted/sdl/pcm-sdl.c [diff]
firmware/target/hosted/sdl/system-sdl.c [diff]
firmware/target/hosted/sdl/thread-sdl.c [diff]
tools/configure [diff]
uisimulator/buttonmap/agptek-rocker.c [diff]
uisimulator/buttonmap/creative-zen.c [diff]
uisimulator/buttonmap/creative-zenxfi3.c [diff]
uisimulator/buttonmap/creative-zv.c [diff]
uisimulator/buttonmap/creative-zvm.c [diff]
uisimulator/buttonmap/erosq.c [diff]
uisimulator/buttonmap/fiio-m3k.c [diff]
uisimulator/buttonmap/gigabeat-s.c [diff]
uisimulator/buttonmap/gigabeat.c [diff]
uisimulator/buttonmap/gogear-hdd1630.c [diff]
uisimulator/buttonmap/gogear-hdd6330.c [diff]
uisimulator/buttonmap/gogear-sa9200.c [diff]
uisimulator/buttonmap/iaudio-m3.c [diff]
uisimulator/buttonmap/iaudio-x5_m5.c [diff]
uisimulator/buttonmap/ihifi2.c [diff]
uisimulator/buttonmap/ipod.c [diff]
uisimulator/buttonmap/iriver-h10.c [diff]
uisimulator/buttonmap/iriver-h100_h300.c [diff]
uisimulator/buttonmap/meizu-m6sl.c [diff]
...and 19 more files.
Solomon Peachy
6th Oct 15:17 d13029ebdd: kernel: Add queue_full() API call

This allows callers to see if it's safe to enqueue something instead of triggering a panic if the queue turns out to be full.
firmware/kernel/include/queue.h [diff]
firmware/kernel/queue.c [diff]
Solomon Peachy
6th Oct 13:30 2f3b9ab68a: tms320dm320: Correct a warning with newer toolchains
firmware/target/arm/tms320dm320/system-dm320.c [diff]
Solomon Peachy
3rd Oct 12:03 8808c42d6d: Fix FS #13494
apps/plugins/imageviewer/imageviewer.c [diff]
Christian Soffke
29th Sep 15:37 0cb0cb486f: tagtree: remove superfluous code from insert_all_playlist

Code has no effect since commit a0e95c8. Functionality is now handled by the playlist_insert_context_add function
apps/tagtree.c [diff]
Christian Soffke
26th Sep 07:29 f09693b0be: [Feature/BugFix] Dirplay never gets the file I selected

If you have say 1000 playlist entries and select the 1001 song in the directory dirplay loads tracks 1-1000 shuffles them and track 1001 is never heard from again

Instead start at the file and loop through the directory mod dir len

Hint: this is a good way to not wait on dirplay to load a ton of tracks
apps/filetree.c [diff]
William Wilgus
26th Sep 05:34 f55cb77f89: [Bugfix] FS #13492 - Playback resume fails after USB insert

On usb plug system_flush() gets called before the other threads get a chance to ACK the insert

system_flush() calls playlist_shutdown() (amongst other things) playlist_shutdown closes the control file

the audio thread acks USB insert audio_stop_playback is called which now can't look up the filename from the now closed handle for control the control file

I left the guard for checking for USB insert but it appears to be fine without it
apps/playlist.c [diff]
William Wilgus
26th Sep 04:38 e6313e4b8e: tree.c remove strlcat in favor of strmemccpy

moved a conditional for reload_dir vs strcmp
apps/tree.c [diff]
William Wilgus
25th Sep 22:08 9ebfb3fa5c: FS #13493: Updated German translation (Wilfried Winkler)
apps/lang/deutsch.lang [diff]
Solomon Peachy
25th Sep 11:01 ef6da7503a: Codecs: mp4: Support object type 29 (AAC LC + SBR + PS).

Backport libfaad commit https://github.com/knik0/faad2/commit/d35cf8f24d55112451074424f8896e695ce9ee6b
lib/rbcodec/codecs/libfaad/mp4.c [diff]
Roman Artiukhin
25th Sep 05:33 9af325a541: [BugFix] tagcache_search() must be closed with tagcache_search_finish()

fix a couple of places where this could be left open
apps/plugins/pictureflow/pictureflow.c [diff]
apps/tagcache.c [diff]
William Wilgus
25th Sep 05:03 a0e95c888d: [Feature/Bugfix] Tagtree use insert context to speed up adding tracks to playlist

I forgot we had duplicated code between playlist.c and tagtree.c this saves a bit of space and should speed up adding tracks a bit

further I noticed a buf here where there was the potential to return without closing the opened track search
apps/tagtree.c [diff]
William Wilgus
25th Sep 04:54 ffebb9e244: [Bugfix] Enable Progressive loading for talk clips on devices <= 8MB

our voiceclips are getting in the way of allocs for the tree on these devices
apps/talk.c [diff]
William Wilgus
24th Sep 21:45 33495ef006: fonts: Major update for 12-Fixed-SemiCond (1767 -> 4531 codepoints)
fonts/12-Fixed-SemiCond.bdf [diff]
Solomon Peachy
24th Sep 14:48 5d2692375d: rbutil: Add erosqnative

- Give each brand its own entry, and make ranges of OF versions correspond to hardware changes.
- Temporarily disabled target aigoerosq.
- Post-install hint enabled.
- Added pre-install hint function
- Added optional parameter themename, in case the target name does not match the themesite name.
- Made Port Status (statusAsString()) only care about platform string prior to first '.'
- Manual: Remove note that rbutil does not support this model

Issues:

- Cannot uninstall the bootloader - manual instructions are available
manual/getting_started/installation.tex [diff]
utils/rbutilqt/base/bootloaderinstallhelper.cpp [diff]
utils/rbutilqt/base/bootloaderinstallhelper.h [diff]
utils/rbutilqt/base/playerbuildinfo.cpp [diff]
utils/rbutilqt/base/playerbuildinfo.h [diff]
utils/rbutilqt/changelog.txt [diff]
utils/rbutilqt/gui/selectiveinstallwidget.cpp [diff]
utils/rbutilqt/gui/selectiveinstallwidget.h [diff]
utils/rbutilqt/rbutil.ini [diff]
utils/rbutilqt/rbutilqt.cpp [diff]
utils/rbutilqt/themesinstallwindow.cpp [diff]
utils/rbutilqt/version.h [diff]
Dana Conrad
24th Sep 14:47 f0c208554c: [BugFix] Playback.c OOM with large voice file

with our large voice file being loaded in its entirety to the buffer there isn't enough room to allocate the required pcm buffer well prior to this patch we looked for 1k free to allow the talk buffer to be given away well the pcm buffer expects something like 5-600 kb on the clipzip and there is 1k allocatable but not 300 more

so instead get the required pcm buffer size and check against that
apps/pcmbuf.c [diff]
apps/pcmbuf.h [diff]
apps/playback.c [diff]
William Wilgus
24th Sep 14:27 c3f51b5fe9: opus: Re-add a ICONST_ATTR lost in 4c6bb798d6bebc80f07e863236adbaf8d156a9c
lib/rbcodec/codecs/libopus/celt/cwrs.c [diff]
Solomon Peachy
24th Sep 11:44 56bd6cd634: fonts: 12-Adobe-Helvetica.bdf: adjust width for few letters

Add more spacing to avoid overlap with other letters (includes A/\W and some more)
fonts/12-Adobe-Helvetica.bdf [diff]
Roman Artiukhin
24th Sep 11:44 306110479c: fonts: 12-Adobe-Helvetica.bdf: add missing Ukrainian letters

Added ІіЇїЄєҐґ
fonts/12-Adobe-Helvetica.bdf [diff]
Roman Artiukhin
24th Sep 11:44 d9c491121c: fonts: 12-Adobe-Helvetica.bdf: Fix metrics by gbdfed

These changes are made by saving the font in gbdfed without any explicit modifications
fonts/12-Adobe-Helvetica.bdf [diff]
Roman Artiukhin
23rd Sep 14:43 ff0ad4ca7d: metadata: aac: support .aac files with mp4 container inside
lib/rbcodec/metadata/aac.c [diff]
Roman Artiukhin
22nd Sep 20:44 77ff799502: lang: Delete two completely redundant strings
apps/lang/english.lang [diff]
apps/menus/eq_menu.c [diff]
Solomon Peachy
22nd Sep 14:41 8f8fb13edb: dbtool: Fix build when we have HOTSWAP but not MULTIVOLUME

(Not sure how that can happen, but... eh)
uisimulator/common/filesystem-sim.c [diff]
Solomon Peachy
22nd Sep 13:20 e5d4e33403: manual: Additional notes about Flash/SSD mods
manual/getting_started/installation.tex [diff]
Solomon Peachy
22nd Sep 12:54 1e7334a22c: manual: Document the 128GB AppleOS limit of early ipod6g models.

(And do some minor massaging of the other storage limit language)
manual/getting_started/installation.tex [diff]
Solomon Peachy
21st Sep 23:08 395311f7a1: simulator: Make sure we define the right stuff for sigaltstack()

We got some of this stuff through SDL1 implicitly.
firmware/export/config.h [diff]
Solomon Peachy
21st Sep 23:08 a7fba55fcf: warble: Fix build
firmware/export/config.h [diff]
Solomon Peachy
21st Sep 20:32 6ed8b9091c: Misc: Compiling under SDL2 uncovered a few issues unrelated to SDL itself
apps/playback.c [diff]
firmware/asm/thread.h [diff]
firmware/include/string-extra.h [diff]
Solomon Peachy
21st Sep 19:14 bc56e9a9dc: SDL: Don't apply settings when starting DMA playback

This seems to be redundant since it already happens in pcm.c
firmware/target/hosted/sdl/pcm-sdl.c [diff]
Christian Soffke
21st Sep 18:51 3f3ec8273a: metadata: aac: Fix any file is treated as valid aac

Fixup for d50470bc
lib/rbcodec/metadata/aac.c [diff]
Roman Artiukhin
21st Sep 17:15 1be795c9b1: fix red thanks to tex4htm being a doody-head
manual/getting_started/installation.tex [diff]
Solomon Peachy
21st Sep 17:01 babc1e57e1: manual: Add a blurb about Windows format tool limitations
manual/getting_started/installation.tex [diff]
Solomon Peachy
21st Sep 15:00 5d6e498178: manual: Document storage/capacity limits and "SSD Mods"
manual/getting_started/installation.tex [diff]
Solomon Peachy
21st Sep 14:48 9a714939e8: features: Add 'sd_storage' if the device uses SD cards
apps/features.txt [diff]
Solomon Peachy
18th Sep 14:43 a056150d52: updatelang: Flag '|' in voice strings too
tools/updatelang [diff]
Solomon Peachy
18th Sep 12:26 e0df9952fd: ata: Alter ata_is_active() when drive doesn't support power management

Due to the heisenberg principle, we don't want to check the battery level when the ATA drive is "spun up".

Unfortunately some ATA devices *cough most SD adapters cough* don't support mandatory ATA power management commands like flushing caches and
(safely) shutting down so we have to leave them "spinning".

This leads to us never updating our battery status with these out-of-spec devices. Work around this issue by having is_active() always return false if that's what we have.
firmware/drivers/ata.c [diff]
firmware/target/arm/s5l8702/ipod6g/storage_ata-6g.c [diff]
Solomon Peachy
17th Sep 15:09 c71b6265b0: Fix a mechanical error in the Simplified Chinese translation
apps/lang/chinese-simp.lang [diff]
Solomon Peachy
17th Sep 14:21 e09c055a41: lang: Replace all <...> with [...]

<..> gets interpreted as a drive/volume ID, which has special voicing rules.

(this is especially visible in the DB browser)
apps/lang/arabic.lang [diff]
apps/lang/basque.lang [diff]
apps/lang/bulgarian.lang [diff]
apps/lang/catala.lang [diff]
apps/lang/chinese-simp.lang [diff]
apps/lang/chinese-trad.lang [diff]
apps/lang/czech.lang [diff]
apps/lang/dansk.lang [diff]
apps/lang/deutsch.lang [diff]
apps/lang/eesti.lang [diff]
apps/lang/english-us.lang [diff]
apps/lang/english.lang [diff]
apps/lang/espanol.lang [diff]
apps/lang/esperanto.lang [diff]
apps/lang/finnish.lang [diff]
apps/lang/francais.lang [diff]
apps/lang/galego.lang [diff]
apps/lang/greek.lang [diff]
apps/lang/hebrew.lang [diff]
apps/lang/hindi.lang [diff]
apps/lang/hrvatski.lang [diff]
apps/lang/islenska.lang [diff]
apps/lang/italiano.lang [diff]
apps/lang/japanese.lang [diff]
apps/lang/korean.lang [diff]
apps/lang/latviesu.lang [diff]
apps/lang/lietuviu.lang [diff]
apps/lang/magyar.lang [diff]
apps/lang/nederlands.lang [diff]
apps/lang/norsk-nynorsk.lang [diff]
...and 18 more files.
Solomon Peachy
17th Sep 14:18 24ae4aee33: updatelang: Expand suspicius character tests.

* dest: < >
* voice: [ ] < > { }
tools/updatelang [diff]
Solomon Peachy

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy