| when | what | where | who |
|---|---|---|---|
| 25th Nov 08:21 | 4e53ec80b5: [Fix Yellow] root_menu.c
|
apps/root_menu.c [diff]
|
William Wilgus |
| 25th Nov 07:48 | 40e685fb71: [Feature] run .link shortcuts within menu shortcuts
|
apps/root_menu.c [diff]
apps/shortcuts.c [diff] |
William Wilgus |
| 24th Nov 21:17 | b6ce98c55c: [BugFix] yesno screen disappears
sending GUI_EVENT_NEED_UI_UPDATE ensured we got redrawn but it also sometimes resulted in the yesno screen being overdrawn depending on which event callback was called last now increasing the update frequency, clear the dirty bit on whatever vp we are replacing and well as call our redraw function instead of sending UI_UPDATE also found a potential bug in get_font() |
apps/gui/yesno.c [diff]
firmware/font.c [diff] |
William Wilgus |
| 24th Nov 02:26 | cb3b5397b3: Revert "Extend path_append_ex to truncate compname, remove some strmemdupa"
This reverts commit dbe20d453d5e93bd0f1188a8851c6cf4fd230b26. Reason for revert: Crashes ipod Classic |
apps/playlist.c [diff]
firmware/common/dircache.c [diff] firmware/common/file.c [diff] firmware/common/file_internal.c [diff] firmware/common/pathfuncs.c [diff] firmware/export/pathfuncs.h [diff] |
William Wilgus |
| 23rd Nov 17:26 | 53a47970e3: [BUGFIX] some files wouldn't run as shortcut
make sure we have a chance to get the dirfilter otherwise it may be rejected adds some sanity checks and safeguards too |
apps/plugins/shortcuts/shortcuts_view.c [diff]
apps/tree.c [diff] |
William Wilgus |
| 22nd Nov 23:58 | 5c60975d4f: Revert "Revert "tree.c cleanup update_dir()""
This reverts commit b6ac9a9f395b486baf5de455cf2505351b32d8ec. Reason for revert: RED Herring |
apps/tree.c [diff]
|
William Wilgus |
| 22nd Nov 18:43 | b6ac9a9f39: Revert "tree.c cleanup update_dir()"
This reverts commit 1d2dfb3a7681ab462bb5ca31d3362dbf2d0fcfcb. Reason for revert: crash on ipod Classic boot |
apps/tree.c [diff]
|
William Wilgus |
| 22nd Nov 16:50 | 1d2dfb3a76: tree.c cleanup update_dir()
|
apps/tree.c [diff]
|
William Wilgus |
| 22nd Nov 05:52 | 72c539d35e: [Bug_Fix] shortcut to directory in .link files caused crash
since the plugin browser is now closed when running plugins rb->set_current_file() had no valid browser context and used 'random' memory instead also adds a way to discard levels so we can load the desired directory instead of returning to the previous https://forums.rockbox.org/index.php/topic,54694.0.html |
apps/filetree.c [diff]
apps/open_plugin.c [diff] apps/plugins/shortcuts/shortcuts_view.c [diff] apps/tree.c [diff] apps/tree.h [diff] |
William Wilgus |
| 21st Nov 21:48 | 6e90bfe029: lcd-color: Fix mpeg_player regression introduced in 034b6d5b
The lcd_blit_yuv() function shadowed a variable, but was "fixed" by removing the inner declaration entirely, causing the inner loop to clobber a variable used by the outer loop. Fix this by declaring these variables independently, and for clarity moved the inner loop declarations to a narrower scope. |
firmware/drivers/lcd-color-common.c [diff]
|
Solomon Peachy |
| 19th Nov 18:20 | 92e77ddbd8: [FIX_RED] microtar.c #2
|
lib/microtar/src/microtar.c [diff]
|
William Wilgus |
| 19th Nov 18:03 | 58707b0429: [FIX_RED] strcmp missing on microtar.c ??
|
lib/microtar/src/microtar.c [diff]
|
William Wilgus |
| 19th Nov 17:35 | 263fc8b98f: [FIX RED] include stdio for snprintf
|
firmware/common/pathfuncs.c [diff]
|
William Wilgus |
| 19th Nov 17:00 | dbe20d453d: Extend path_append_ex to truncate compname, remove some strmemdupa
remove some duplicated strings previously allocd off the stack just removing string duplications that are easily handled with truncation now available with path_append_ex() this also has an advantage of less stack used in worst case scenarios |
apps/playlist.c [diff]
firmware/common/dircache.c [diff] firmware/common/file.c [diff] firmware/common/file_internal.c [diff] firmware/common/pathfuncs.c [diff] firmware/export/pathfuncs.h [diff] |
William Wilgus |
| 19th Nov 00:13 | a7d0ff2000: Playlist Viewer: Reload indices after saving currently playing playlist
First index may have changed |
apps/playlist_viewer.c [diff]
|
Christian Soffke |
| 18th Nov 15:29 | 35f9a5b415: Skin Engine: Fix loading images with same file name
Looks like this was a regression introduced in 01cbb79. The duplicate img uses an existing buflib handle for the data, but still didn't have access to the dimensions from the bitmap struct. Test case: DancePuffDuo theme for Sansa E200. Only one dancepuff was displayed. Thank you to goatikins for reporting the issue. |
apps/gui/skin_engine/skin_parser.c [diff]
|
Christian Soffke |
| 15th Nov 22:49 | 5114827937: Fix: Rotate indices after saving playlist w/ first_index > 0
When saving the current playlist, entries written out to disk were rotated, but its indices were not, resulting in first_index being out of sync between the two. Thus, an incorrect index was used for any playlist commands, from the moment you saved the playlist until the next time you resumed, which didn't produce the right playlist. |
apps/playlist.c [diff]
apps/root_menu.c [diff] |
Christian Soffke |
| 12th Nov 01:49 | bd93f9f96f: Increase playlist control file's version number
This should have probably been included in e9b4275, since a control file generated with that build will potentially cause issues when used with older versions, in case -8 appears as an insert position. |
apps/playlist.c [diff]
|
Christian Soffke |
| 10th Nov 23:36 | a82b30735d: Fix queued track when resuming after PLAYLIST_COMMAND_CLEAR
PLAYLIST_COMMAND_CLEAR needs to save the index of the currently playing track, or a track with index 0 will be left queued after resuming from control commands |
apps/playlist.c [diff]
|
Christian Soffke |
| 10th Nov 23:36 | ba14aecd5e: Fix INSERT_LAST_SHUFFLED when playlist's first_index > 0
Tracks were inserted into the middle of the playlist |
apps/playlist.c [diff]
|
Christian Soffke |
| 10th Nov 23:36 | 8a6aaaa5ed: Playlist Viewer: Make Shuffle behave like Reshuffle
Moves currently playing track to the front of the playlist when shuffling. Also fixes issues with an incorrect resume index after repeatedly applying shuffle. |
apps/playlist_viewer.c [diff]
|
Christian Soffke |
| 10th Nov 23:36 | d4f1247aec: Playlists: Fix moving songs in reshuffled playlist
The current index wasn't always correct after moving in a playlist with first index > 0 |
apps/playlist.c [diff]
|
Christian Soffke |
| 10th Nov 23:36 | e9b4275d1f: Playlists: Fix resuming from control commands with first_index > 0
add_track_to_playlist_unlocked only increased a playlist's first index as necessary when its position parameter was negative (i.e. one of the special insert positions was specified). A negative value was not stored in the control file, but was always converted into an absolute position. Thus, any adjustments to first_index weren't repeated when resuming from the control file. In particular, shuffled playlists were affected (in case of first_index > 0), when inserting at positions <= first_index, including appending a track to the end of a playlist. This works by inserting at first_index and increasing first_index by 1 afterwards. Similarly, adding tracks in a shuffled fashion could increase first index, whenever that was the value randomly calculated for a track position, effectively appending it (I assume this is on purpose). To make sure that first_index adjustments are recovered when resuming from the control file, and to be able to differentiate between a prepended or appended track, store the special value PLAYLIST_INSERT_LAST_ROTATED as the insert position in the control file whenever first_index would have been used before, and a special position (other than PLAYLIST_PREPEND) was provided to the function. |
apps/playlist.c [diff]
apps/playlist.h [diff] |
Christian Soffke |
| 10th Nov 23:17 | dd1063fc2c: [BUGFIX] path_append_ex() component string
basepath_max is used to truncate basepath but was being applied to component as well in error |
firmware/common/pathfuncs.c [diff]
|
William Wilgus |
| 10th Nov 02:03 | 7ac4d34dd6: Playlist slight optimizations for playlist_resume
|
apps/playlist.c [diff]
apps/playlist.h [diff] firmware/common/pathfuncs.c [diff] firmware/export/pathfuncs.h [diff] |
William Wilgus |
| 9th Nov 07:06 | 7f455af905: hwstub lib: Introduce framework for device filtering
The rationale behind this was ability to filter usb device by bus numer and device address. This allows to connect with selected device in case there is more then one connected device implementing hwstub interface. For now only USB backend makes use of this but the foundation is generic and can be easily extended to other backends. |
utils/hwstub/include/hwstub.hpp [diff]
utils/hwstub/include/hwstub_usb.hpp [diff] utils/hwstub/lib/hwstub_uri.cpp [diff] utils/hwstub/lib/hwstub_usb.cpp [diff] |
Marcin Bukat |
| 3rd Nov 03:48 | 154f10c2d2: boost cpu when resuming playlists
|
apps/playlist.c [diff]
|
William Wilgus |
Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy