Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide
translations



whenwhatwherewho
Yesterday 16:33 7b12cc3927: pathfuncs.c remove strip_leading_separators()

This should actually be strip_extra_leading_separators() but its not used anywhere else yet and I don't see enough callers in core to make it worth the extra overhead
firmware/common/pathfuncs.c [diff]
firmware/export/pathfuncs.h [diff]
William Wilgus
Friday 14:56 ae25a425b6: ATA: Fix regression when trying to set power management mode with CF cards

Some CF cards claim to support Advanced Power Management, but error out when the command is issued. There is a special case in the code that ignored errors when issuing the APM command, but was referenced against a specific index in the feature table.

When the tagle was reorganized, the index was wrong depending on if ATA_DMA was enabled or not.

The fix is to test against the specific subcommand ID instead of the table index.
firmware/drivers/ata.c [diff]
Solomon Peachy
Friday 05:40 de4a08f319: [Bugfix] filetree.c ft_assemble_path() absolute currdir

path_append throws away the basepath if currdir starts with a slash I thought I had this fixed but it was just getting covered up

instead step past all the slashes and use that for our append dir
apps/filetree.c [diff]
William Wilgus
Thursday 11:52 935fb736e8: [FixRed] tagcache.c

I think this should be APPLICATION for hosted
apps/tagcache.c [diff]
William Wilgus
Thursday 11:17 633b06dcfe: [Bugfix] tagcache.c reverse conditional for native targets
apps/tagcache.c [diff]
William Wilgus
11th Jun 19:21 4d9c7e2063: Improve the "No partition found" behavior.

(This is a different implementation of the fix in g#5726, by Vencislav Atanasov)

The core problem is that the user is prompted to insert a USB cable to fix the partitioning etc but the code that monitors for USB insertion hasn't been started yet. Correct this.

If no USB support is present, reboot after 5 seconds if it's not a debug build.

If USB support is present, want for insertion first, then do the reboot-if-not-debug behavior.
apps/main.c [diff]
Solomon Peachy
11th Jun 14:13 ec23260fd1: mikmod: Settings names should _NOT_ be i18n'd.

Regression was introduced back in 2019 in 2ebb8da275
apps/plugins/mikmod/mikmod.c [diff]
apps/plugins/text_viewer/tv_menu.c [diff]
Solomon Peachy
11th Jun 14:13 11c70c6164: MAINTAINERS: Add our German translation maintiner
docs/MAINTAINERS [diff]
Solomon Peachy
11th Jun 13:53 c97954f014: FS #13434: Partially internationalize the textviewer plugin

* Converted over all previously-translated strings
* Lots of comments added to mark the next phase
* Voice filename of the file being loaded if possible
apps/plugins/text_viewer/text_viewer.c [diff]
apps/plugins/text_viewer/tv_action.c [diff]
apps/plugins/text_viewer/tv_bookmark.c [diff]
apps/plugins/text_viewer/tv_display.c [diff]
apps/plugins/text_viewer/tv_menu.c [diff]
apps/plugins/text_viewer/tv_pager.c [diff]
Solomon Peachy
9th Jun 13:03 8c6b579b32: FS #13435: Update Polish Translation (Adam Rak)

...Also list Adam as the Polish language maintainer
apps/lang/polski.lang [diff]
docs/MAINTAINERS [diff]
Solomon Peachy
9th Jun 13:03 8259c12a2f: docs: Update MAINTAINERS file to add a "this is pretty out of date" blurb

List myself as the active maintainer of a few more pieces
docs/MAINTAINERS [diff]
Solomon Peachy
8th Jun 23:03 b222e909d4: lang: Update english-us "translation"
apps/lang/english-us.lang [diff]
Solomon Peachy
8th Jun 23:03 810e337a87: xduoox3: It doesn't have a radio, so don't put that in APPEXTRA
tools/configure [diff]
Solomon Peachy
7th Jun 22:10 46ec07e4be: mikmod: partial revert of previous commit.

The strings in the struct configdata[] are only used in the settings file, and not displayed. Therefore there is no need to translate them.
apps/plugins/mikmod/mikmod.c [diff]
Solomon Peachy
7th Jun 21:47 20f50bbca3: plugins: mikmod and chessbox weren't fully translated

This unfortunately required adding four more strings.
apps/lang/english.lang [diff]
apps/plugins/chessbox/chessbox.c [diff]
apps/plugins/mikmod/mikmod.c [diff]
Solomon Peachy
7th Jun 16:21 92b5255106: lang: Add a few more items to the "ignore if same as English" list
tools/langignorelist.txt [diff]
Solomon Peachy
7th Jun 16:21 b9e6e67962: voice: Switch default piper voice for Italian
tools/voice.pl [diff]
Solomon Peachy
7th Jun 04:38 3b9d804bdf: [coverity] playlist.c format_track_path() guard NULL pointers
apps/playlist.c [diff]
William Wilgus
7th Jun 04:25 4829c2c894: [coverity] settings.c int_to_string() string_to_int() guard NULL deref
apps/settings.c [diff]
William Wilgus
6th Jun 14:53 dbdcd8425a: [coverity] tagtree.c tagtree_exit() ensure dirlevel is within bounds

max I could get was 5 with the default tagnav cfg but we allow user code too so might be possible to exceed the depth
apps/tagtree.c [diff]
William Wilgus
6th Jun 03:38 f9b15d951c: [coverity] folder_select.c find_from_filename() guard against NULL

its pretty doubtful you wouldn't find a slash in a folder path
apps/gui/folder_select.c [diff]
William Wilgus
6th Jun 00:03 c6473f4e7f: [Fix Yellow] imx233_debug fix yellow
firmware/target/arm/imx233/debug-imx233.c [diff]
William Wilgus
5th Jun 23:16 c96d728d81: [coverity] debug-imx233.c dbg_hw_info_audio() use strlcat, fix snprintf call

technically this isn't currently causing any issue but coverity correctly identified the potential for buffer ovfl
firmware/target/arm/imx233/debug-imx233.c [diff]
William Wilgus
5th Jun 23:16 d68c314cea: [coverity] vuprintf.c format_double_radix() initialize data struct

it appears this is false positive but its compliaining about the uninitialized pointer, not a bad idea to initialize pointers to NULL anyway
firmware/common/vuprintf.c [diff]
William Wilgus
5th Jun 23:13 e54dedd8df: [coverity] fat.c fatlong_parse_entry() buffer overrun, fix warning basisname

BYTES2INT16() uses [i + 0] and [i + 1] therefore 30 is the max element available in the raw byte array of size 32

(((uint32_t)array[pos+0] << 0) | \
((uint32_t)array[pos+1] << 8))

struct /* raw byte array */
{ uint8_t data[32];
};

basisname is only uninitialized in the . and .. dir entries both are likely false positives but cheap enough to guard against
firmware/drivers/fat.c [diff]
William Wilgus
5th Jun 23:00 74552d5404: [coverity] RFC ata-imx31.c UDMA mode timing tables out of bounds reads

mode only goes 0-4 the original commit mixed up the index and mode bad stuff must happen but its been here for 16 years
firmware/target/arm/imx31/ata-imx31.c [diff]
William Wilgus
4th Jun 23:29 2109d524e8: samsung yp-r0: Fix displaying non-Latin filenames on SD card

Supply iocharset=utf8 mount option. Otherwise, cyrillic symbols appear as question marks.
firmware/target/hosted/samsungypr/ypr0/system-ypr0.c [diff]
Roman Artiukhin
4th Jun 21:40 fb39d852b0: [coverity] tagtree.c tagtree_enter selected_item_history guard against overrun
apps/tagtree.c [diff]
William Wilgus
4th Jun 21:18 1b7d35126b: [coverity] playlist.c pl_save_update_control fix rest of potential fd leaks
apps/playlist.c [diff]
William Wilgus
4th Jun 19:56 dad01f29ff: [coverity] multiboot.c write_bootdata_ fix memset size

the payload arg was swapped with the size arg
firmware/common/multiboot.c [diff]
William Wilgus
3rd Jun 02:14 afba86f0f7: [coverity] playlist.c pl_save_update_control() close fd on error
apps/playlist.c [diff]
William Wilgus
3rd Jun 02:07 283f31dd39: [coverity] language.c lang_load() check bytes read for headers
apps/language.c [diff]
William Wilgus
3rd Jun 01:48 ce6fbe4382: [coverity] cuesheet.c search_for_cursheet() if no dot strcpy to NULL

the logic here is a bit fuzzy to me maybe one of the copies to the cuepath buffer adds a dot but I don't see anything explicit
apps/cuesheet.c [diff]
William Wilgus
3rd Jun 01:40 f4a044e561: [coverity] playlist.c get_track_filename() uninitialized buffer

format_track_path() uses path_append_ex() which might use strlen on the existing buffer likely a false positive but cheap enough to guard against
apps/playlist.c [diff]
William Wilgus
3rd Jun 01:00 2903a8e8ac: [coverity] tlsf.c tlsf_malloc guard against empty mempool

on error mp could still be NULL
lib/tlsf/src/tlsf.c [diff]
William Wilgus
2nd Jun 21:09 82dcf32736: [BugFix] headphone should be removed on first toggle
firmware/target/hosted/sdl/button-sdl.c [diff]
William Wilgus
2nd Jun 21:09 31ae252dcc: [BugFix] Resume on headphone plug causes screen glitches
apps/misc.c [diff]
William Wilgus
2nd Jun 16:42 bbdba53413: [coverity] bookmark.c fix add_bookmark & false positive in remove_bookmark
apps/bookmark.c [diff]
William Wilgus
2nd Jun 15:13 2e60316500: [coverity] skin_parser.c load_skin_bitmaps check buffer length for bm_data
apps/gui/skin_engine/skin_parser.c [diff]
William Wilgus
2nd Jun 14:41 5c7fbe8f1b: [coverity] tree.c set_current_file_ex explicitly check strrchr output

the math size_t endpos = filename - path; if (filename && endpos < MAX_PATH - 1) should handle it just fine coverity doesn't think so
apps/tree.c [diff]
William Wilgus
2nd Jun 14:32 cc67f420f2: [coverity] font.c load_cache_entry check for successful read
firmware/font.c [diff]
William Wilgus
1st Jun 22:27 5d34887d4a: voice: regression: Don't mangle the filename when spelling it out.

26c612f breaks file selections if you have filename extensions disabled and filenames spelled out, because it modified the filename in place breaking the caller.

Instead of using a lot of space to make a private copy, the simplest approach is, if we strip the extension off, simply restore it afterwards.
apps/tree.c [diff]
Solomon Peachy
1st Jun 19:07 e16230de8c: FS #13433: Updated German Translation (Wilfried Winkler)
apps/lang/deutsch.lang [diff]
Solomon Peachy
1st Jun 16:40 bcd34cfaa7: playlist catalogue (etc.): prune context menu

"Create Directory" option not applicable in browse filter modes, since directories do not get displayed
apps/onplay.c [diff]
Christian Soffke
1st Jun 16:25 507fa214a8: Fix red in 3d7d1d4d
apps/plugins/lib/SOURCES [diff]
Christian Soffke
1st Jun 15:55 3d7d1d4d5b: plugins: properties: show track info for whole playlist

Track Info can now be displayed for the set of all tracks contained in a playlist. This lets you calculate a playlist's length, for example, even if it is not currently playing.

This functionality can be accessed from the existing "Properties" screen for a selected playlist file. A line has been added at the very bottom to show Track Info.
apps/misc.c [diff]
apps/misc.h [diff]
apps/playlist.c [diff]
apps/playlist.h [diff]
apps/plugin.c [diff]
apps/plugin.h [diff]
apps/plugins/properties.c [diff]
apps/tagtree.c [diff]
Christian Soffke
1st Jun 15:42 ef1e7d8896: bookmarks: show 'Create Bookmark' for unsaved playlists

Instead of hiding this option when the current playlist is unsaved, we can offer to save the playlist, if necessary, before attempting to create a bookmark.

This simplifies the workflow by getting rid of steps 1 and 2 that a user currently needs to perform:

1) Open context menu, check if "Create Bookmark" option is available 2) If not: Re-open context menu. Select Current Playlist
-> Save Current Playlist 3) Re-open context menu. Select Bookmarks
-> Create Bookmark
apps/bookmark.c [diff]
apps/onplay.c [diff]
manual/configure_rockbox/bookmarking.tex [diff]
manual/main_menu/main.tex [diff]
manual/rockbox_interface/wps.tex [diff]
Christian Soffke
1st Jun 03:02 d1aeb7db9d: [Coverity] playback.c audio_auto_change_frequency check for valid id3
apps/playback.c [diff]
William Wilgus
31th May 01:22 eaeaac598d: FS #13431: Provide a way to view the rockbox license in the menus

This adds a "Legal Notices" entry under the System menu that will launch the text viewer plugin to display:

1) COPYING.txt (containing the GPLv2 overall license for Rockbox) 2) LICENSES.txt (containing all other relevant licenses and notices)
apps/lang/english-us.lang [diff]
apps/lang/english.lang [diff]
apps/menus/main_menu.c [diff]
Solomon Peachy
31th May 01:02 d22dbe74cb: updatelang: '~' is not a legal character in dest or voice strings

...Unless it's the very first character (and will get stripped).

So detect and complain about this!
tools/updatelang [diff]
Solomon Peachy
31th May 00:01 f0c1cf1eef: Update US English "Translation"
apps/lang/english-us.lang [diff]
Solomon Peachy
30th May 23:49 09e01c89a7: FS #13430: Updated German translation (Wilfried Winkler)
apps/lang/deutsch.lang [diff]
Solomon Peachy
30th May 16:12 aca41be3ca: [Feature] Simulator add headphone and lineout toggling
firmware/target/hosted/sdl/button-sdl.c [diff]
uisimulator/common/sim_tasks.c [diff]
uisimulator/common/sim_tasks.h [diff]
uisimulator/common/stubs.c [diff]
William Wilgus
30th May 15:01 7ec1151ddd: [BugFix] add button maps for iPod6GSim
uisimulator/buttonmap/ipod.c [diff]
William Wilgus
26th May 15:53 3a60f3a0f7: better Cyrillic for 14-Rockbox-Mix
fonts/14-Rockbox-Mix.bdf [diff]
fonts/COPYING [diff]
Andrey Maluy
26th May 15:51 e72bae7c3f: [Superdom] Bugfix

Prevents the plugin from locking up on the highest difficulty level
apps/plugins/superdom.c [diff]
Franklin Wei
25th May 18:33 4e54443dc9: manual: Document the fact that checkwps can validate %Sx theme tags
manual/appendix/wps_tags.tex [diff]
Solomon Peachy
25th May 01:37 8b8c0c7c2a: checkwps: Validate translated strings (%Sx)

In verbose mode it will log valid the strings found, otherwise it will only complain when we encounter a missing string.

Unfortunately a missing string is not inherently a problem, due to conditional expressions. So all we can do is complain in checkwps or if wps debugging is turned on.

Meanwhile, this is the first step in actually enumerating the translated strings used by themes.
apps/gui/skin_engine/skin_parser.c [diff]
apps/gui/skin_engine/wps_internals.h [diff]
apps/lang/english.lang [diff]
firmware/export/button.h [diff]
firmware/export/config.h [diff]
tools/checkwps/SOURCES [diff]
tools/checkwps/checkwps.c [diff]
tools/checkwps/checkwps.make [diff]
tools/configure [diff]
Solomon Peachy
24th May 16:11 ac20f8a73c: lang: Delete 12 unused strings
apps/bookmark.c [diff]
apps/lang/english-us.lang [diff]
apps/lang/english.lang [diff]
Solomon Peachy
24th May 15:34 5dd9238004: Fix yellow in sim builds
lib/skin_parser/skin_debug.c [diff]
Solomon Peachy
24th May 15:17 8825b33052: skin_debug: Don't segfault when dump a viewport with no children
lib/skin_parser/skin_debug.c [diff]
Solomon Peachy
22nd May 12:52 2dc6947a2d: lang: Get rid of *unused* LANG_EQUALIZER_EDIT_MODE and all deprecated strings

The documentation says to not delete things but that dates back to when we were a lot laxer in what we would accept at runtime.

I want to make things even stricter, and add a checksum or hash of the string IDs, so that *any* change to the base language invalidates translation and voice binaries at runtime.
apps/lang/english-us.lang [diff]
apps/lang/english.lang [diff]
Solomon Peachy

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy