FS#10078 - crash in text editor

Attached to Project: Rockbox
Opened by Wolfgang Dilg (rasferret) - Tuesday, 31 March 2009, 08:56 GMT
Last edited by Teruaki Kawashima (teru) - Saturday, 02 October 2010, 04:40 GMT
Task Type Bugs
Category Plugins
Status Closed
Assigned To No-one
Operating System Sansa e200
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


in r20588 open the attached file while playing a mp3 file. open context menu by pressing the down button. when pressing the power off button the player crashes. if there is no playback when pressing the power off button nothing happens.
This task depends upon

Closed by  Teruaki Kawashima (teru)
Saturday, 02 October 2010, 04:40 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed in r28189.
Comment by Wolfgang Dilg (rasferret) - Tuesday, 31 March 2009, 08:57 GMT
you have to open the file with the text editor of course.
Comment by Thomas Martitz (kugel.) - Tuesday, 31 March 2009, 15:00 GMT
Can you test some archives build (and/or 3.2)? I think this bug wasn't there a few revisions ago.
Comment by Wolfgang Dilg (rasferret) - Tuesday, 31 March 2009, 15:01 GMT
I'll give it a try tonight...
Comment by Wolfgang Dilg (rasferret) - Wednesday, 01 April 2009, 09:47 GMT
I think I've tracked down the cause of the crash.
It seems to be the setting bookmark on stop. With a clean install of rockbox 3.2

show files: all
autocreate bookmarks: on

in config.cfg the player crashes as described before (show files: all doesn't matter but
is needed for me to start playing a file using the file browser)
With 3.1 and before the player ignores pressing the power button, so there is no crasch.
With 3.2 the player stops playback and when it tries to create the bookmark it crashes.

I hope this information is enough for tracking down the bug.
Comment by Thomas Martitz (kugel.) - Wednesday, 01 April 2009, 09:49 GMT
The text editor uses standard button contexts, which includes stopping playback with power. Virtually no other plugin does this.

Trying to create a bookmark when in a plugin in a backdoor'ish way can be problematic, I imagine.
Comment by Teruaki Kawashima (teru) - Friday, 01 October 2010, 14:55 GMT
Wolfgang, could you test if the bug still happens with the latest build (r28189 at this time)?
Comment by Wolfgang Dilg (rasferret) - Friday, 01 October 2010, 15:13 GMT
I think the crash is gone. The text editor just ignores pressing the power button when displaying the text. When you change into the context menu the power button stops the playback and a bookmark is created.
good job :-)