Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To
    jdgordon
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.2
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by teru - 2009-04-04
Last edited by jdgordon - 2009-07-03

FS#10094 - Replace oldmenuapi menu/customed menu in plugins by standard menu

this patch replaces menu of the following plugins by standard menu.

plugins using oldmenuapi:
doom
pacbox
reversi
solitaire
sudoku
random_folder_advance_config
fireworks
jpeg
mpegplayer
rockboy
viewer
zxbox
test_sampr
test_disk

plugins using its own menu:
jewels
chessclock

plugins whose menu is NOT replaced:
rockpaint
- this plugin has file browser and it needs some work to turn to standard menu.

   plugins_standard_menu.patch (76 KiB)
Closed by  jdgordon
2009-07-03 04:44
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

this has been open for long enough… if any bugs come up new tasks can be opened

teru commented on 2009-05-20 14:27

updated patch.
removed unrelated changes and fixed wrong changes.

   plugins_standard_menu.2.patch (74.8 KiB)
teru commented on 2009-05-23 13:10

attempt to replace rockpaint's menu by standard menu.
i'm not sure if i'm doing things correctly for browser, but it seems to work.
not done for font selection.

   rockpaint.diff (24.7 KiB)
teru commented on 2009-06-03 12:59

update patches and divide to some parts.

*standard_menu_for_plugins.3.patch
this patch replaces oldmenuapi by standard menu simply and won't have any issue.

*standard_menu_for_plugins_with_tweak.3.patch
this patch replaces oldmenuapi by standard menu with smoll change.
-jpeg,viewer
move "Quit" from top to button item of menu just like other plugins.
-rockboy
use simplelist_info for loading/saving game.
-solitaire
use differt menu wheter being in game.
make "Draw Three Cards"/"Draw One Card" to option "Draw Cards Option".

*standard_menu_for_doom.3.patch
this patch replaces oldmenuapi by standard menu for doom.
this contains large change for creating item and selecting item for "Addons","Demos" witch may contain problem.

*standard_menu_for_mpegplayer.3.patch
i'm not sure if changes relating to mpeg_menu_sysevent_callback is correct.

*standard_menu_for_custom.3.diff
this is patch for replacing customed menu by standard menu.

   standard_menu_for_plugins.3.p... (19.8 KiB)
   standard_menu_for_plugins_wit... (15.3 KiB)
   standard_menu_for_doom.3.patch (8.2 KiB)
   standard_menu_for_mpegplayer.... (8.8 KiB)
   standard_menu_for_custom.3.di... (48.9 KiB)
jdgordon commented on 2009-06-03 16:25

are those all seperate patches that can be aplied in any order?
I cant see oldmenu.c being removed there.. does that mean not all plugins are converted after these? I'll look into commiting this before he weekend (hopefully)

teru commented on 2009-06-04 13:01

yes, they can. these patches are independent each other.
more strictly, independent against each plugin.
i converted all plugins using oldmenuapi unless i missed something.
the reason why removal of apps/plugins/lib/oldmenuapi.c is not included is that I thought that it's not late to remove oldmenuapi.c after these patches are commited and problems are not reported.

teru commented on 2009-06-06 03:51

I had uploaded wrong standard_menu_for_plugins_with_tweak.3.patch, sorry… it dousen't do what i said for viewer.
> move "Quit" from top to button item of menu just like other plugins.
this is the correct one.

   standard_menu_for_plugins_wit... (15.6 KiB)
jdgordon commented on 2009-06-16 04:26

Accepted. Thanks….

I'm going to leave this open for a while in the hope that any problems that come up will get posted here.

perfectdrug commented on 2009-06-16 11:07

I think it was more convenient to have the "quit" entry at the top of the list, in the jpegviewer, to easily exit the plugin without further keypresses, I think having "return" at the top is not intuitiv because if you press stop you normally don't want to undo this action.

teru commented on 2009-06-17 14:47

"Quit" is at the bottom of the menu for (almost) all other plugins (if it has one), and it confused me that the "Quit" was not at where i expected (i.e. the bottom of the menu).
I'm wondering why there isn't key assigned to quit jpegviewer directly.
About "Return", maybe it can be dropped because user can return by pressing left?

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing