Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category LCD
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by idak - 2009-05-11
Last edited by Unhelpful - 2009-05-15

FS#10201 - Fix album art file search priority

Album Art file search order of priority is described as the following:
— 

 1. ./ filename . ext - same filename as currently playing music file
 2. ./ albumtitle . ext - name of the album, found in metadata of the music file
 3. ./cover. ext
 4. ./folder.jpg
 5. /.rockbox/albumart/ artist-albumtitle . ext
 6. ../ albumtitle . ext
 7. ../cover. ext

— But, “./folder.jpg” priority is higher than “./cover.bmp”.
This patch fixes this issue.

   cover.bmp (29.3 KiB)
   folder.jpg (1.9 KiB)
   aasearch_prio.patch (0.5 KiB)
Closed by  Unhelpful
2009-05-15 23:27
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Suggested fix of skipping folder.jpg with size_string committed as r20951.

idak commented on 2009-05-13 10:38

To be exact, above issue is WPS behaviour.
And pictureflow’s Album Art file search order of priority is different from WPS.
#pictureflow priority is as wiki.

So I’m confused.
Which priority is correct?
Or different priority is intentioned?

rasher commented on 2009-05-13 17:27

I don’t understand how your patch changes the search order?

Also, both PictureFlow and the WPS use the same function when searching for AA, so I find it hard to believe that they use different priority.

idak commented on 2009-05-14 14:32

WPS calls search function(search_albumart_files()) twice.

First one is with size_strings (like “.100×100“) and
Second one is without size_strings (like ““).
So WPS exact search order is the following.
– o First call
1. ./filename.100×100.bmp
2. ./albumtitle.100×100.bmp
3. ./cover.100×100.bmp
4. ./folder.jpg «< without size_string!
5. /.rockbox/albumart/artist-albumtitle.100×100.bmp
6. ../albumtitle.100×100.bmp
7. ../cover.100×100.bmp

o Second call
8. ./filename.bmp
9. ./albumtitle.bmp
10. ./cover.bmp
11. ./folder.jpg « never select because above 4. priority is high
12. /.rockbox/albumart/artist-albumtitle.bmp
13. ../albumtitle.bmp
14. ../cover.bmp
–

And PictureFlow calls search function(search_albumart_files()) once
without size_string.
So PictureFlow search order is above “Second call”(8. - 14.).

As the result, WPS loads “folder.jpg”, but PictureFlow loads “cover.bmp”.
This patch is that if size_string is “” then “folder.jpg” search is skipped.

learman commented on 2009-05-14 14:34

WPS album art first looks for files with a specific size in their name (e.g., “cover100x100.bmp”), then without. The patch makes the search skip the generic “folder.jpg” (always is without size) when looking for files with a specific size. This also explains why PictureFlow behaves differently, as it doesn’t look for files with a specific size.

The patch looks correct to me.

(Edit: Darn, too late. :) )

pondlife commented on 2009-05-14 15:11
both PictureFlow and the WPS use the same function when searching for AA, so I find it hard to believe that they use different priority

This might not be true at the moment, but it ought to be MADE true,…!

idak commented on 2009-05-14 15:14
This patch is that if size_string is “” then “folder.jpg” search is skipped
This patch is that if size_string is _not_ “” then “folder.jpg” search is skipped

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing