FS#10269 - Philips GoGear HDD6330 - Rough cut of new port

Attached to Project: Rockbox
Opened by Robert Menes (RMenes379) - Monday, 01 June 2009, 22:35 GMT
Last edited by Robert Menes (RMenes379) - Monday, 18 October 2010, 12:48 GMT
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Operating System Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


This patch adds the Philips GoGear HDD6330 to the build system as a new target. Normally, one would have to tweak the code for the HDD1630 to build for this device, but now you can do so without the tweaking.

This patch is still extremely rough, and it doesn't build correctly yet. It errors out when constructing rockbox.elf, so maybe someone with more experience can take a look at it and see where it goes wrong.

As the HDD6330 is largely similar to the HDD1630, sound, LCD, FM radio, and more should work. There is no touchpad driver, so control is still very rough. But it's the start of something, and should make it easier to finish up the port now. :)
This task depends upon

Closed by  Robert Menes (RMenes379)
Monday, 18 October 2010, 12:48 GMT
Reason for closing:  Out of Date
Additional comments about closing:  Some new work related to this port had been committed earlier in the year. This is old, outdated, and kludgey code.
Comment by Maurus Cuelenaere (mcuelenaere) - Tuesday, 02 June 2009, 15:46 GMT
You forgot setting the correct SVN keyword settings on new files:
svn pdel svn:executable [FILES]
svn pset svn:eol-style native [FILES]
svn pset svn:keywords 'Author Date Id Revision' [FILES]
Comment by Robert Menes (RMenes379) - Tuesday, 02 June 2009, 15:51 GMT
Crap, I keep forgetting that.

I'll do so and post a new patch.
Comment by Maurus Cuelenaere (mcuelenaere) - Tuesday, 02 June 2009, 15:52 GMT
You can edit your ~/.subversion/config to do some of this automatically ;) ( )
Comment by Mark Arigo (lowlight) - Tuesday, 02 June 2009, 16:12 GMT
I have a hdd6330 tree from some time ago when we first got it working. There's no need to duplicate all those files since they are identical for the hdd1630 and there are no functional changes or ifdefs needed. Instead, I renamed the target directory to "hdd1630_hdd6330" and renamed the existing files except the lcd files. The tree looks something like:

philips/hdd1630_hdd6330/lcd-as-hdd1630.S < for hdd1630 only
philips/hdd1630_hdd6330/lcd-hdd1630.c < for hdd1630 only
philips/hdd1630_hdd6330/lcd-hdd6330.c < for hdd6630 only

I understand what needs to be done with the touchpad, but I probably need a device to test the changes. I doubt it needs it's own driver file though. I'm assuming you have the lcd driver I wrote. It uses basic transfers, however, the OF disassembly indicates that it can do block transfers. So that will need some work. Also, there is no "lcd-as" file for the hdd6330, so no mpegplayer.

Perhaps it is best if I update find time to my tree and post a patch.
Comment by Robert Menes (RMenes379) - Tuesday, 02 June 2009, 18:47 GMT
Mark, I have a GoGear HDD6330 here. If you'd like, I could help test patches to see if everything works.