FS#10289 - Icons in the playlist viewer are not shown if the filetype icons are set to 'off'

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Saturday, 06 June 2009, 22:44 GMT
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 16 December 2009, 08:37 GMT
Task Type Bugs
Category Playlists
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Set the following settings:

'Show icons' in the theme settings to "No"
'Show icons' in the playlist viewer settings to "Yes"

Under this circumstances, I'd expect the marker of the current song in the playlist to be shown. The same for the marker of the moved song (while moving a song in the playlist). But the markers are not shown.

Tested with r21166 (not the latest today, but I think there were no code changes in this area)
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Wednesday, 16 December 2009, 08:37 GMT
Reason for closing:  Fixed
Additional comments about closing:  better solution is to move the settings check out into the calling code... r24022.
Comment by Nils Wallménius (nls) - Sunday, 07 June 2009, 08:14 GMT
This happens because list_draw() checks the "Show icons" setting directly and doesn't draw icons if that is set to no.
not sure how to fix that in a nice way though, a simple hack in that function could special case for the playlist viewer but, well it's hacky
otherwise we might need to make the callers tell it if icons should be drawn or not...
Comment by Alexander Levin (fml2) - Sunday, 07 June 2009, 09:34 GMT
Or we could have two functions for drawing lists. One would work as the current one (since it's used in most cases), and the other would have a parameter telling what to draw.