FS#10424 - [wav codec] wav codec supports some ADPCM formats

Attached to Project: Rockbox
Opened by Yoshihisa Uchida (Uchida) - Friday, 10 July 2009, 12:45 GMT
Last edited by Maurus Cuelenaere (mcuelenaere) - Saturday, 20 February 2010, 12:04 GMT
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


wav codec supports the following ADPCM formats:
- Microsoft ADPCM
- Dialogic Oki ADPCM
- Yamaha ADPCM

It is necessary to apply the patch of  FS#10422 ,  FS#10423 .
This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Saturday, 20 February 2010, 12:04 GMT
Reason for closing:  Accepted
Additional comments about closing:  In r24782.
Comment by alex wallis (alexwallis646) - Tuesday, 14 July 2009, 14:32 GMT
this task appears to depend on other tasks according to the description, so perhaps this should also be made a dependency of them.
Comment by alex wallis (alexwallis646) - Tuesday, 14 July 2009, 21:31 GMT
this patch will not apply, I have applied fs #10422 and fs #10423.
Comment by Yoshihisa Uchida (Uchida) - Thursday, 16 July 2009, 14:11 GMT
In my build environment, these patches apply success.

Please tell me the error message when the patch is applied.

My build environment
Windows Vista + Cygwin

Comment by alex wallis (alexwallis646) - Thursday, 16 July 2009, 14:48 GMT
Hi. for fs #10432 the error when the patch is applied is
patching file apps/codecs/codecs.make
Hunk #1 FAILED at 78.
1 out of 1 hunk FAILED -- rejects in file apps/codecs/codecs.make

that is the only file that has a problem.

The same error appears to happen on fs#10433.

I am running the latest svn code. It does have some patches on, but none of them touch the files yours do. I did try applying only your patches and still got problems.
Comment by MichaelGiacomelli (saratoga) - Tuesday, 21 July 2009, 19:16 GMT
Hi, I emailed you last month about your patches to the email in your contact info. Did you get my email?
Comment by Yoshihisa Uchida (Uchida) - Saturday, 06 February 2010, 09:13 GMT
I am not good at anything by the current illness. Because I had recovered from the illness at last, I can restart this correction.
Please wait for a new patch for a while.
Comment by Yoshihisa Uchida (Uchida) - Tuesday, 16 February 2010, 09:12 GMT
new patch applied.

- sync r24691
- seek process corrects.
- I corrected to seek to dialogic oki adpcm, non block header yamaha adpcm format wave file.
(Because the definition of get_seek_pos() had been changed, I changed all wave formats.)
- I changed 'chunksize' value for all wave formats.
- I changed set_formats(). (fmtops does not used.)

Comment by Yoshihisa Uchida (Uchida) - Saturday, 20 February 2010, 10:02 GMT
I commit this patch (see r24782) but I cannot close my task.
please close this task.
Comment by Maurus Cuelenaere (mcuelenaere) - Saturday, 20 February 2010, 12:04 GMT
> but I cannot close my task

Please ask for Flyspray developer rights in IRC.