FS#10637 - Error after MPC file

Attached to Project: Rockbox
Opened by dar02 (dar02) - Saturday, 03 October 2009, 10:27 GMT
Last edited by Andree Buschmann (Buschel) - Sunday, 07 March 2010, 20:29 GMT
Task Type Bugs
Category Codecs
Status Closed
Assigned To Andree Buschmann (Buschel)
Operating System iPod 5G
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


When you will try to play Muspack (mpc) song encoded by last version of Muspack encoder (1.30.0) (SV8 file) wich will not play because SV8 MPC files are not supported by rockbox right now - the rockbox is not able to play any other song until reboot.
This task depends upon

Closed by  Andree Buschmann (Buschel)
Sunday, 07 March 2010, 20:29 GMT
Reason for closing:  Fixed
Additional comments about closing:  Closed as sv8 is supported from r25057.
Comment by MichaelGiacomelli (saratoga) - Saturday, 03 October 2009, 21:35 GMT
Rockbox doesn't support SV8 because theres no SV8 decoder.
Comment by dar02 (dar02) - Sunday, 04 October 2009, 07:10 GMT
I know that this file is not supported, but the Rockbox is loosing stability when it is trying to play it. And after that you can't open any other files like mp3, wma, etc...
Comment by MichaelGiacomelli (saratoga) - Sunday, 04 October 2009, 15:15 GMT
You're right I'm not sure how I misunderstood you so completely. I will look at this today.
Comment by Andree Buschmann (Buschel) - Sunday, 24 January 2010, 15:40 GMT
When working on this bug I got really confused. First I very quickly found out that the header parsing is not correct for the final sv8 bitstream release. The attached patch corrects the mpc header parsing. Neverthless the error still occurs.

Some more details:
1. As soon as a single mpc-file was selected that results "false" in metadata.c (case AFMT_MPC:), the mpc-codec quits (which is correct) and afterwards playback is totally blocked.
2. If I change the code in apps/metadata/mpc.c to return "true" for sv8-files, everything works fine. In this case the playback of this file is rejected within the codec-loop. In this case the playback is not blocked afterwards.
3. Playback is only blocked after a broken track is selected that is not the last in the current playlist!
4. This is also happening with mpa-files.

Any suggestions from the codec engine experts?
Comment by Andree Buschmann (Buschel) - Sunday, 24 January 2010, 16:51 GMT
I opened up a new bug report ( FS#10930 ) as this is not only relevant for mpc, but will happen with each non-playable/corrupted audio file.
Comment by Andree Buschmann (Buschel) - Sunday, 31 January 2010, 11:45 GMT
Sumitted parser bugfix with r24408. Nevertheless a fix of  FS#10930  is needed to really fix the blocking of the playback engine.
Comment by Andree Buschmann (Buschel) - Saturday, 06 March 2010, 16:02 GMT
Will be fixed with commit of  FS#11079  (full mpc sv8 support).