Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Codecs
  • Assigned To No-one
  • Operating System SW-codec
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by midgey34 - 2009-10-19
Last edited by midgey34 - 2010-02-03

FS#10690 - Add 24-bit support to ALAC decoder

I’ve merged in the changes from 0.2.0 of the ALAC decoder upstream into our implementation. Enables 24-bit ALAC files to playback. Seems to work on all of my samples. I did my best to mimic the current style of the code.

I’d like to make sure this doesn’t overflow IRAM on any target (I can only build for ARM at the moment…). I’m also a bit unsure about the parts where uncompressed bytes are copied into our output buffer. Should that data be shifted?

   24bit_alac.diff (21.5 KiB)
Closed by  midgey34
2010-02-03 00:46
Reason for closing:  Accepted
Admin
fg commented on 2009-10-19 10:26

Builds find on all currently auto-built targets

midgey34 commented on 2009-10-20 01:11

The patch above is a bit slower than SVN. This is fixed in the patch below (it’s actually about 0.5% faster…). I used test_codec to dump one of my 16-bit test files and it dumped the same wave as SVN.

Still not sure about the part where it copies uncompressed bytes into the output buffer.

   24bit_alac.2.diff (23 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing