Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System Cowon D2
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Teruaki Kawashima - 2010-01-21
Last edited by Teruaki Kawashima - 2010-06-27

FS#10925 - basic touchscreen support for virtual keyboard

Johannes Schwarz pointed out that virtual keyboard lacks support for touchscreen. so i tried to add one.
but i don’t actually understand how touchscreen works and don’t have tagert to test on. so, feel free to improve, customize or even reject.
tocuh character to input a character.
tocuhing right side changes the page if there is more than one.
tocuh left/right side of edit line to move cursor left/right by one char.
morse input support is not added.
text on buttons is not localized.

probably this is not so usable especially for default keyboard with system font because of too small grid for character selection.
maybe it can be improved by defining something like MIN_GRID_SIZE and use it instead of font width or font height.

Closed by  Teruaki Kawashima
2010-06-27 14:09
Reason for closing:  Accepted
Additional comments about closing:  

Committed in r27156.

Maurus Cuelenaere commented on 2010-01-21 11:02

I've tested this on both sim & target (Onda VX747), works great!

It does need to be set with FONT_UI however to be useable on target, and you'll have to keep in mind that the sides of a touchscreen are much less responsive (at least, on the Onda that is) wrt the buttons.

I've attached a quick&dirty patch that sets the current font to FONT_UI, but I think in the long term we should have some kind of multifont support and can set different fonts for different contexts (list font, WPS font, keyboard font, etc..).

Teruaki Kawashima commented on 2010-01-21 11:46

Thank you for testing.
> you'll have to keep in mind that the sides of a touchscreen are much less responsive (at least, on the Onda that is) wrt the buttons.
it is good to know. but i realy want someone willing to improve this considering i don't have one to test on.

It does need to be set with FONT_UI however to be useable on target,
how about my idea to define MIN_GRID_SIZE per target and use MAX(MIN_GRID_SIZE, font_h) or MAX(MIN_GRID_SIZE, font_w)? user font may not be large enough.
or is there anything bad other than the selector is too small?
Maurus Cuelenaere commented on 2010-01-21 12:54
it is good to know. but i realy want someone willing to improve this considering i don't have one to test on.

Sure, I'm interested in doing that (will look at it later).

how about my idea to define MIN_GRID_SIZE per target and use MAX(MIN_GRID_SIZE, font_h) or MAX(MIN_GRID_SIZE, font_w)? user font may not be large enough.

If it does what I think it does (setting a minimum size for each grid element) then it seems as a good idea.
Still I prefer to have multifont in the long term, but this solution is good enough for now.

or is there anything bad other than the selector is too small?

I'm not sure what you mean with the selector being too small?

Teruaki Kawashima commented on 2010-01-21 13:21
Still I prefer to have multifont in the long term, but this solution is good enough for now.
well, i didn't intend to be against this

i meant the selector = inverted part of vkeyboard to select which charactar to insert.

Teruaki Kawashima commented on 2010-01-24 13:21

* implemented my idea about MIN_GRID_SIZE.
* added morse code input support.
* always use ui fonts for buttons and chaged position of page flip button.

Teruaki Kawashima commented on 2010-01-31 15:38

synched patch.
edit: remove unrelated change.

Teruaki Kawashima commented on 2010-02-14 06:00

update patch.

Teruaki Kawashima commented on 2010-06-24 13:25
Maurus Cuelenaere commented on 2010-06-24 14:37

Looks OK, you will need to add LANG_* tags for Ok, Delete and Cancel though.

Teruaki Kawashima commented on 2010-06-26 13:08

update
* add LANG strings.
* enlarge bottom buttons.

Maurus Cuelenaere commented on 2010-06-26 14:28

I think this can go in.

Teruaki, you have commit rights, don't you?

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing