Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by jdgordon - 2010-05-12
Last edited by jdgordon - 2010-05-16

FS#11263 - Radio art

This makes the %Cl and %C tags work in the fm screen skin!

to use it you must be in presets mode, and have a preset file loaded. then in the fmpresets folder you need one .bmp for each station named the same as it is in the presets file.

this first version only loads bmp…

   radioart.1.diff (3.8 KiB)
Closed by  jdgordon
2010-05-16 11:14
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

in r26078

mc2739 commented on 2010-05-13 02:42

Updated patch to correct compile errors (changed strncpy to strlcpy)

   radioart.2.diff (3.8 KiB)
jdgordon commented on 2010-05-13 11:00

this version stores 10 images so there should be no load at all when changing stations if the image was loaded already.
It will fail if more than 10 images need to be loaded though (simple fix but running out now)

   radioart.2.diff (4.7 KiB)
jdgordon commented on 2010-05-13 14:52

Fix %?C not working and %C for radio not working in sbs.

dump the oldest image if we need to load more than 10, or there isnt enough room on the buffer (pretty much untested).

This is commitable now except going into the recording screen then back into fm with a station expecting an image will very likely crash the player!

Also seach for .jpg in the same folder (.bmp first though.. order can be changed)

   radioart.3.diff (7.1 KiB)
mc2739 commented on 2010-05-13 17:47

%?C and .jpg support tested - no problems detected

Entering recording screen from fm screen caused: Data abort at 00008ea4 (0)
This happens even after stopping the fm radio. If you start playback and then go to the recording screen, it does not crash.

jdgordon commented on 2010-05-14 02:26

thanks, yeah that is what I was expecting. I'm not entirely sure how to make this perfectly safe but I'll play today if I get a chance

jdgordon commented on 2010-05-14 06:11

This should fix the recording problems. It isnt really as clean as I would like though… please let me know if it does work (radioart should stop working as soon as you try recording. stopping the recording should make it work again)

   radioart.4.diff (9.4 KiB)
mc2739 commented on 2010-05-15 00:24

No more crashes with this latest patch. On e200, when recording, it goes to the recording screen, so no radioart anyway.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing