Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#11396 : the wps_time_countup member of sruct wps_state is neverer written, only read.

Rockbox

Tasklist

FS#11396 - the wps_time_countup member of sruct wps_state is neverer written, only read.

Attached to Project: Rockbox
Opened by Nils Wallménius (nls) - Saturday, 12 June 2010, 12:49 GMT
Last edited by Andree Buschmann (Buschel) - Tuesday, 25 January 2011, 21:41 GMT
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

As the title says this struct member is never written to, so it should always be false (0).
it is checked on line 321 of wps.c but this test (comparing to false) is always true which looks like a bug.
This task depends upon

Closed by  Andree Buschmann (Buschel)
Tuesday, 25 January 2011, 21:41 GMT
Reason for closing:  Accepted
Additional comments about closing:  Changed with r29139.
Comment by Jonathan Gordon (jdgordon) - Saturday, 12 June 2010, 15:03 GMT
I haven't looked at it yet but sure if you want to remove it go for it. I'm doing a massive rework on the skin system probably removing that struct in the. Process.

Loading...