- Status Closed
- Percent Complete
- Task Type Patches
- Category Codecs
-
Assigned To
Buschel - Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Release 3.6
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#11450 - faad compiler option
svn uses -O1 to compile libfaad. When compiling with -O2 the decoder gets reasonable faster on PP5022 (iPod Video). The attached patch changes the compile option for libfaad to -O2.
Please post results with -O1 (svn) against -O2 (patch) on other targets to this flyspray entry.
iPod Video (PP5022): 31.6 MHz (svn 32.4 MHz) for nero_192.m4a
Closed by Buschel
2010-07-05 19:29
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2010-07-05 19:29
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Submitted with r27297
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Pretty output with http://www.rockbox.org/wiki/bin/viewfile/Main/CodecPerformanceComparison?filename=parse_testcodec.pl.txt;rev=5 arguments: log_svn.txt log_O2.txt
Tested on Clip+
So 02 makes it about 5% faster
Note that aache fails to decode with or without the patch
AAC-HE is fixed with r27232.
Gives about 1-2 % speedup on h300 (mcf5249) for the nero_*.m4a files in test_files.
In fact, it seems O1 is even better for coldfire. (Os is used in svn)
I ran a set of test_codec benchmarks and posted my tunings in
FS#11450in those tests faad was fastest with O3 on c200v1 and with O1 on h300.Did you test with O3 on your ipod?
On a Fuze V2, -O3 is slightly slower than -O2 (well, only ~1.2 percent, so that's perhaps within the margin of error). Only tested 128 and 192 kbps; got an empty result file when I tried a full folder test…
Still, this makes AAC about as fast as Vorbis on a Fuze V2 (a little slower at 128 kbps, a little faster at 192 kbps).
For iPod Video (PP5022) the difference between -O3 and -O2 is measurable but not significant (see below). But the code size increases by 20% (202 KB → 243 KB).
-O1: 32.43 MHz -O2: 31.64 MHz -O3: 31.59 MHz
Therefore I propose to change the compile switch to -O2 for ARM and -O1 for non-ARM.
Here's the patch.
Thanks, please commit it