Rockbox

Tasklist

FS#11473 - New bookmarking option: one per track

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Monday, 12 July 2010, 20:43 GMT
Last edited by Solomon Peachy (pizza) - Sunday, 23 December 2018, 22:36 GMT
Task Type Patches
Category Settings
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch implements the idea proposed and discussed in http://forums.rockbox.org/index.php?topic=24952.0

It adds a new option of how to create and maintain the list of the recent bookmarks (MRB): one per track. With this option, if a bookmark is added to the MRB, other bookmarks from the same playlist and the same track are not retained.

Comments are welcome.

I think it would be good if we could introduce such option for "normal" bookmark files too, i.e. to store only one bookmark per track in a bookmark list. But this would be matter of a separate patch.
   bm_per_track.diff (7.6 KiB)
This task depends upon

Closed by  Solomon Peachy (pizza)
Sunday, 23 December 2018, 22:36 GMT
Reason for closing:  Accepted
Additional comments about closing:  An updated version of this patch has been merged.
Comment by Alexander Levin (fml2) - Tuesday, 13 July 2010, 16:51 GMT
The new patch also updates the manual section with config file options.
   bm_per_track2.diff (8.3 KiB)
Comment by Alexander Levin (fml2) - Wednesday, 14 July 2010, 21:33 GMT
Bin and RAM sizes for Sansa e200 v1 (target build):

Unpatched:
Version: r27423-100714
Binary size: 585728
Actual size: 584724
RAM usage: 1522048

Patched:
Version: r27423M-100714
Binary size: 585728 (+0)
Actual size: 584940 (+216)
RAM usage: 1522272 (+224)
Comment by Alexander Levin (fml2) - Wednesday, 14 July 2010, 21:56 GMT
Get rid of a compile warning in bookmark.c (possibly uninitialized variable)
   bm_track3.diff (8.3 KiB)
Comment by Marek Salaba (salaba) - Saturday, 21 August 2010, 12:43 GMT
It is very usefull function.
Salaba
Comment by AJ Thorton (ajthorton) - Thursday, 09 September 2010, 22:50 GMT
I love this! Very useful.
Comment by Solomon Peachy (pizza) - Friday, 14 December 2018, 13:04 GMT
It's taken eight years, but a heavily updated version of this patch has finally landed in master. :)

Loading...