Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Music playback
  • Assigned To
    Thomas Jarosch
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.6
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Tim Middleton - 2010-07-22
Last edited by Thomas Jarosch - 2011-03-03

FS#11493 - bookmark on stop doesn't work on sleep timeout

This used to work, I think back in 3.4.

While (settings → general → bookmarking) “bookmark on stop” is enabled, when the player is stopped via (system → time & date) sleep timer, a bookmark is not created before the player powers down.

Closed by  Thomas Jarosch
2011-03-03 00:27
Reason for closing:  Fixed
Additional comments about closing:  

Thanks for the initial patch!

I verified the code paths and fixed it properly.

For the record:
clean_shutdown() calls audio_stop() after the bookmark creation (as it's supposed to be).

Marek Salaba commented on 2010-08-22 08:52

I tested on Sansa Fuse v2 r27850 and If I have set function "bookmark on stop" on "yes" and set "sleep timer", the bookmark don't created.
Salaba

Teruaki Kawashima commented on 2010-10-15 13:42

this seems to fix the bug.

   bookmark_sleeptimer.diff (0.7 KiB)
Torne Wuff commented on 2010-10-15 13:49

That only fixes it for the case where the player isn't plugged in.

Andy Smith commented on 2010-11-06 12:51

Can second this, very annoying bug.

Andy Smith commented on 2010-11-06 12:52

Almost making me go back to original firmware for Sleep Timer it's so annoying !

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing