Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Codecs
  • Assigned To No-one
  • Operating System SW-codec
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.6
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Nils Wallménius - 2010-07-24
Last edited by Andree Buschmann - 2011-04-27

FS#11495 - playback of atrac3_rm files sometimes fails.

If i start playback of a track and then swithc to a atrac3_rm file i sometimes get “codec failure” on my h300. Starting to play the file when playback is stopped seems to work fine all the time. I could not reproduce this on the simulator or on my gigabeat S.

Edit:
logf prints “parsing packets failed” from librm/rm.c:520
and then “rm_get_packet failed” from atrac3_rm.c:114

Edit again:
this is the file http://samples.mplayerhq.hu/real/AC-atrc/GoodbyeCaroline.rm

Closed by  Andree Buschmann
2011-04-27 20:14
Reason for closing:  Fixed
Additional comments about closing:  

Fixed with submission of playback engine rework (r29785).

Andree Buschmann commented on 2010-07-24 20:09

This may be an endianess issue. When taking a look at the read functions there are "be" and "le" defined to read from the given buffer. Those are used the same way for all targets (even though targets differ in their endianess)… For a single target "be" and "le" version are used… Maybe Mohamed Tarek can give more input here.

Edit: On the other hand endianess issues should show such error always and not only sometimes…

Andree Buschmann commented on 2011-02-03 13:01

I have similar issues on my iPod Video. The failure cannot be reproduced in sim.

Have a folder with the following files:
1) DearJohn.rm
2) FUN_RM_132.rm
3) GoodbyeCaroline.rm
4) KingOfTheJailHouse.rm

Observed:
A) When playing 1) and then start to play 2) vie directly selecting 2) from the filebrowser, track 2) is not played. Playback skips to 3)
B) When playing 1) and then skip to 2), track 2) plays fine.
C) When coming from another codec (e.g. mp3) and directly selecting track 2) from the file browser it plays fine.
D) Track 4) behaves exactly like track 2).

To me this looks like a re-initialization error.
Question i: What is the difference between skip fwd and selecting from file browser?
Question ii: What happens when rentering the codec?

Andree Buschmann commented on 2011-02-03 16:25

After lots of code changes the best way to work around this issue is to add a sleep() (see patch). With this patch I could only very rarely reproduce the issue.

To me this looks like some timing thing (the CPU load for atrac3 is really high on PP502x!). Is it possible that the id3v2 metadata which is parsed by the decoder is not filled in time? This could explain why this only happens when

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing