FS#11546 - Adjustable brightness in lamp plugin

Attached to Project: Rockbox
Opened by Calvin Walden (clone4crw) - Monday, 16 August 2010, 18:52 GMT
Last edited by Teruaki Kawashima (teru) - Saturday, 06 November 2010, 13:46 GMT
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Here's a small patch I wrote that adds the ability to adjust the brightness of the lamp plugin. It uses the NEXT/PREV keys that would normally duplicate the functionality of LEFT/RIGHT to cycle through the colors.

It was made for the Sansa e200 and Fuze, where NEXT/PREV are mapped to the scroll wheel.

Created in daily build 100816.
This task depends upon

Closed by  Teruaki Kawashima (teru)
Saturday, 06 November 2010, 13:46 GMT
Reason for closing:  Accepted
Additional comments about closing:  commited as r28519
Comment by Rafaël Carré (funman) - Sunday, 22 August 2010, 19:51 GMT
Please remove the tabs and change the manual accordingly

If you need help with the manual ask pixelma on IRC
Comment by Thomas Martitz (kugel.) - Sunday, 22 August 2010, 19:52 GMT
The purpose of lamp is to give light in dark situations, I don't see how lowering the brightness adds anything to that.
Comment by Calvin Walden (clone4crw) - Sunday, 22 August 2010, 19:56 GMT
Here is a revised version, with tab characters replaced by spaces
Comment by Calvin Walden (clone4crw) - Sunday, 22 August 2010, 19:58 GMT
I get that the purpose is provide light, but often times the backlight at full brightness is often hard on the eyes at night, and is often unnecessary when combined with the wheel light of the Sansa.
Comment by Teruaki Kawashima (teru) - Tuesday, 02 November 2010, 13:22 GMT
re-implement this...
- add the functionality for all possible targets.
- add button table to the manual.
Comment by Thomas Martitz (kugel.) - Tuesday, 02 November 2010, 13:24 GMT
I still don't see the point but if you want it so much commit it already :)