• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Operating System/Drivers
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.6
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Jonathan Gordon - 2010-11-14
Last edited by Jonathan Gordon - 2011-09-18

FS#11758 - lock the audio buffer with a mutex and minimise its direct use

things shouldnt use audiobuf directly, so this patch works to get rid of that.

buffer_claim() is used to lock the buffer and _unclaim() is to release it. I put a panic in buffer_alloc() when it is unclaimed but that caused problems because untill audio starts nothing really claims the buffer, so we need to work out how to make his actually work.

Right now only playback.c mp3data.c and talk.c still use audiobuf directly (which needs to be changed)

not really sure how far to take this.

Closed by  Jonathan Gordon
2011-09-18 07:39
Reason for closing:  Out of Date


Available keyboard shortcuts


Task Details

Task Editing