FS#12032 - disktidy crashes in the simulator

Attached to Project: Rockbox
Opened by Frank Gevaerts (fg) - Monday, 28 March 2011, 17:36 GMT
Last edited by Boris Gjenero (dreamlayers) - Monday, 05 December 2011, 17:39 GMT
Task Type Bugs
Category Simulator
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.8
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


The problem seems to be that while sim_readdir() uses struct sim_dirent, disktidy.c uses the host dirent structure, and those are different
This task depends upon

Closed by  Boris Gjenero (dreamlayers)
Monday, 05 December 2011, 17:39 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in r31089 via  FS#12414 
Comment by Thomas Martitz (kugel.) - Wednesday, 10 August 2011, 14:30 GMT
The problem is that plugin.c sets readdir (and friends) to sim_readdir, which is wrong if the target has dircache. For dircache it needs to be readdir_cached (which internally calls readdir_uncached aka sim_readdir).
Comment by Michael Chicoine (mc2739) - Monday, 03 October 2011, 21:57 GMT
I have gathered some more information concerning this bug.

1. md5sum, random_folder_advance_config, stats, and properties also have problems (segfault) in the simulator
2. the w32 crosscompiled sim also crashes when these plugins are run
3. disabling dircache does not help
4. bisecting shows the first failing revision to be r28929
Comment by Fred Bauer (freddyb) - Tuesday, 29 November 2011, 15:03 GMT
Does r31089 fix this?
Comment by Michael Chicoine (mc2739) - Wednesday, 30 November 2011, 00:14 GMT

The listed plugins now function correctly.