Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.8
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Frank Gevaerts - 2011-04-02
Last edited by Frank Gevaerts - 2011-04-10

FS#12041 - Backdrops outside of .rockbox/backdrops can't be used any more

Since r28073/r28074, bmp files outside of .rockbox/backdrops can not be used at all any more. Before then, they could be set but the setting didn’t survive a reboot.

The attached patch checks for .rockbox/backdrops and doesn’t show the relevant context menu item if invoked outside of .rockbox/backdrops. I’m not entirely sure if the check is always correct, or if maybe there’s a better way to do it.

Ideally of course the backdrop setting should accept any path instead of just relative paths based in .rockbox/backdrops (or even just filenames?).

Closed by  Frank Gevaerts
2011-04-10 13:26
Reason for closing:  Accepted
Additional comments about closing:  

r29700

Admin
Frank Gevaerts commented on 2011-04-02 17:24

This patch allows loading of backdrops from anywhere, and keeps those backdrops after reboot.

I’m not entirely sure if my change to settings_list.c is correct, but the thing seems to work for me.

As far as I can see, the new code structure since r28073 doesn’t make it easy to go back to the old behaviour of only persisting backdrops in .rockbox/backdrops. I’m not sure if we really want to go back to that though, most people used to be surprised by that behaviour.

Admin
Frank Gevaerts commented on 2011-04-04 09:09

A simplified version of the previous one, thanks to a better understanding of how the settings actually work. Not tested yet.

Jonathan Gordon commented on 2011-04-10 13:18

looks good and quick tes here works, commit it when you can be bothered

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing