Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Database
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.8.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by sinless - 2011-04-15
Last edited by nls - 2011-06-02

FS#12065 - Database RAM cache doesn't work with Chinese-simp

when using simp-chinese and open database RAM cache, enter database choose one of the sections,rockbox then freeze.only happens with simp-chinese.have already tested on 7 ipods.gen1~5 have the same problem,ipod classic will show a data abort.

Closed by  nls
2011-06-02 14:26
Reason for closing:  Fixed
Additional comments about closing:  

Better to reopen if needed

The data abort show on ipod classic is:
Data abort
at 00000528
FSR 0XF7
(domain 15,fault 7)
address 0xb6ac02c8

nls commented on 2011-05-02 08:48

This is reproducible on a sim, The crash happnes in strlen called from tagcache:get_next (line1487 in todays svn) because a pointer passed to strlen is corrupted i haven’t found why though

I also found this on SA9200.

There’s a good chance that this regression was introduced with r26192 ( FS#10976  - make the <Untagged> string translatable). I found a problem with this change when I was working on  FS#12132 :

* The translation was done too early: before the tagnavi format clauses were checked. This prevented comparisons against “<Untagged>” when a non-English translation was active.
* The code overwrote the buffer containing the constant string “<Untagged>” with the translation. This is neither safe nor necessary: The result pointer simply can be swapped with a pointer to the translation.

Could you please check whether either backing out r26192 or applying the attached patch fixes the problem?

nls commented on 2011-05-29 17:43

Good catch, that patch does indeed fix the crash

Fix committed as r29941.

I’ll close this task in a couple of weeks unless someone reports that the problem remains or any regressions pop up.

It works now,thanks~

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing