FS#12288 - Sansa Clip+: "Home" in the main menu to WPS/Radio

Attached to Project: Rockbox
Opened by Felipe (flaps) - Wednesday, 21 September 2011, 01:31 GMT
Last edited by MichaelGiacomelli (saratoga) - Saturday, 25 February 2012, 21:15 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Provides an easy way to access the WPS (or previous music) from the main menu, by pressing home a second time.
This is specifically for the Clip/Clip+, because of its limited number of buttons, so as to keep the ui unaltered for the other players.
This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Saturday, 25 February 2012, 21:15 GMT
Reason for closing:  Accepted
Comment by Lukas (mfe555) - Saturday, 24 September 2011, 18:09 GMT Comment by Akio Idehara (idak) - Thursday, 06 October 2011, 12:42 GMT
This patch is what I want!
I vote for it.
Two key combo is too difficult to press with one hand.
Comment by Bertrik Sikken (bertrik) - Tuesday, 11 October 2011, 18:13 GMT
I like the idea of this patch, but I think it's better to do this by editing the keymap tables than by adding #ifdefs in the menu code.
Comment by Akio Idehara (idak) - Wednesday, 12 October 2011, 15:32 GMT
This patch adds support for selecting Home key role in setting menu.
Comment by Shiloh Hawley (gree665) - Saturday, 22 October 2011, 23:50 GMT
Just got a clip+, and after being annoyed by the impossibility of pressing home+select with one hand, I made a patch for my build to do just this. I was going to submit it here, then I found you guys beat me to it. Good job, thanks!
Comment by Rafaël Carré (funman) - Tuesday, 20 December 2011, 01:12 GMT
Please don't add a new setting for this, just enable your key shortcut for everybody.

It looks useful to me, please give a new patch editing the keymap files like bertrik suggested
Comment by Akio Idehara (idak) - Tuesday, 20 December 2011, 15:17 GMT
It's the keymap editing version.
Comment by Rafaël Carré (funman) - Tuesday, 20 December 2011, 17:33 GMT
The 2 added tables are identical ? (with_combo and without_combo)

Also I don't know if the hold_lr ... setting applies in this case.

Does it?
Comment by Akio Idehara (idak) - Wednesday, 21 December 2011, 12:10 GMT
Thank you for commenting.
I simplified the code a bit.
Is it OK?
Comment by MichaelGiacomelli (saratoga) - Wednesday, 22 February 2012, 21:00 GMT
The current version of the patch looks good to me.
Comment by Bertrik Sikken (bertrik) - Thursday, 23 February 2012, 15:13 GMT
I'm no keymap code expert, but I very much like the user experience of this patch.
Comment by Rafaël Carré (funman) - Friday, 24 February 2012, 04:15 GMT
works for me, please commit it