FS#2598 - APEv2 tags for MP3
Opened by Frederic devernay (fredyd) - Tuesday, 26 July 2005, 14:12 GMT
Last edited by Jonathan Gordon (jdgordon) - Thursday, 17 April 2008, 13:06 GMT
|
DetailsHello,
APEv2 and id3v1 tags can be used to tag any file format. When a file has both tags, id3v1 is at the end and APEv2 just before it. This patch fixes this and adds tags handling for any file format (even wavpack, which had only APEv2 tags). For mpa (mp1,mp2,mp3), if the user choses to use id3v1 tags in favor of id3v2, APEv2 tags won't be parsed either. |
Thursday, 17 April 2008, 13:06 GMT
Reason for closing: Rejected
Additional comments about closing: Discussed many times and the official word is we dont want to support APEv2 (or any other non standard tags)
Since those parts of the code are moving fast, please ask me
for an up-to-date patch that applies to the current CVS :
fdy at melix dot net
This new version is much smaller, and adds APEv2 tags
support to MP3 with very little modifications of the
existing code...
I did a really small update so that it applies to current
CVS. I'm going to post the new version
http://deathwind.free.fr/.fdgjkhkfgj/ApeV2_uptodate.patch
So I think it's likely that this task will be rejected unless anyone can come up with a good justification for supporting both id3v2 and apev2 in MP3 files.
In any case, if an id3v2 tag is found, Rockbox won't look for an id3v1 tag anyway, meaning there is nothing to combine a seek for an APEv2 tag with. i.e. if Rockbox supported APEv2, it would always perform an extra seek/read for all files with an id3v2 tag.