FS#2677 : independent visible selection for the statusbar

Status Closed
Percent Complete
100%
Task Type Patches
Category User Interface → Themes
Assigned To No-one
Operating System
Severity Low
Priority Very Low
Reported Version
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by thewolfwillcome - 2005-09-12
Last edited by thewolfwillcome - 2005-11-20

FS#2677 - independent visible selection for the statusbar

I have made a little patch to select when the statusbar
will be visible.
With this patch you must change two settings to archive:
Statusbar both, WPS only, Browser only

I have only updated the english.lang file to reflect
the additional setting.

Real Name: Stephan Wezel

PS: Could some of the admins please delete the same
patch report from anonymouse. I had forgotten to login
while summiting the patch.

wps-sb-tag.patch (14.5 KiB)

Closed by bluebrother
2006-08-26 12:15
Reason for closing: Out of Date
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

the discussed wps tag has been implemented (as discussed in the comments)

Comments (22)
Related Tasks (0/0)

rasher commented on 2005-09-12 22:26

Why the need for two options? Why not just have the option
be a 4-choice one?

Off
Always on
WPS only
Browser only

thewolfwillcome commented on 2005-09-12 23:49

this is my first one ;) I must decover how a multiple choice
works ;) then i can reduce the two options to one

rasher commented on 2005-09-12 23:57

Fair enough. To be honest, I have no idea myself. Look
around other similar options and see how it works is all the
advice I have to offer.

thewolfwillcome commented on 2005-09-13 01:11

So here the new patch with an 4-choice option ensteed the 2
seperate one in the first patch

linusnielsen commented on 2005-09-13 04:02

I think a better solution would be to have a WPS tag that
could control the status bar. Then there wouldn't be a need
for an extra option.

thewolfwillcome commented on 2005-09-13 07:58

Ok i have added the WPS tag "%we"(enable statusbar) and
"%wd"(disable statusbar) to override the global statusbar
setting.

linusnielsen commented on 2005-09-13 09:27

I think the statusbar 4-option setting is unnecessary with
the WPS tag addition. Also, I think the wps_statusbar flag
shouldn't be in the global_settings struct.

thewolfwillcome commented on 2005-09-13 10:27

Ok Owk now with original statusbar option(on/off) and only
the 2 wps-tags

I leave the other patches for someone who whant the 4-choice
option :)

linusnielsen commented on 2005-09-13 10:38

It would be nice if the patch file only contained the
relevant changes.

thewolfwillcome commented on 2005-09-13 11:14

so patch cleaned up as far as possible

linusnielsen commented on 2005-09-13 11:31

Why have you changed all status_draw(xxx) calls to

if(global_settings.statusbar)