FS#3058 - working rockbox with button for iPod 3G

Attached to Project: Rockbox
Opened by slimx (slimx) - Wednesday, 22 February 2006, 21:21 GMT
Last edited by mike (ssnajper) - Thursday, 23 February 2006, 03:54 GMT
Task Type Patches
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


try it and smile :)
   patch.txt (39.3 KiB)
This task depends upon

Closed by  Dave Chapman (linuxstb)
Saturday, 17 February 2007, 02:46 GMT
Reason for closing:  Accepted
Additional comments about closing:  This code must have been committed in the past...
Comment by mike (ssnajper) - Thursday, 23 February 2006, 03:54 GMT

Thanks for your unbelievable work slimx!

Can you please get this added to cvs and make a 3g
bootloader so it will be more simple to install? (with a
seperate daily builds for 3g)

Thanks a ton once again!
Comment by MichaelGiacomelli (saratoga) - Thursday, 23 February 2006, 18:47 GMT
I've uploaded a bootloader to the Ipod Install wiki page. It works for me, so it should be fine for all 3Gs. If you have a problem, let me know, or just build your own (instructions are on the wiki, and compared to adding that patch, its painless :) )
Comment by slimx (slimx) - Thursday, 23 February 2006, 22:49 GMT
I don't know how daily build works, and i have no cvs write access.
but i agree mike it will be much simpler to install and try.
you can find my bootloader here and i'll add my current
so it will be easy for users .....
Comment by Daniel Stenberg (bagder) - Thursday, 23 February 2006, 22:57 GMT
I'm adding a 3G build (and bootloader) right now.
Comment by Daniel Stenberg (bagder) - Thursday, 23 February 2006, 23:09 GMT
But then of course, it doesn't build fine (yet).
Comment by Dave Chapman (linuxstb) - Friday, 24 February 2006, 10:19 GMT
A couple of comments about the patch:

1) Firstly, some cosmetic issues - the patch makes a lot of white-space changes to existing files),including adding TAB characters (which aren't allowed in the Rockbox source). Also, your use of white space isn't consistent,- e.g. sometimes you use two spaces either side of an ||, and sometimes none.

2) The diff to pcm_playback.c creates a duplicate of what looks like an old (i.e. buggy) version of the WM8975/WM8758 code. This shouldn't be necessary - you should be able to use (by defining the appropriate macros, or adding a small number of #ifdefs) the existing code without needing to create a copy of it (but I realise the audio driver is still in the early stages).
Comment by slimx (slimx) - Friday, 24 February 2006, 20:31 GMT
ok so here is a new patch against current cvs without any TAB char and corrected #ifdefs directives.
it's done against current cvs and would build cleanly (i've tested it in a new fresh cvs directory)

I've removed pcm_playback code as Dave have done in current cvs.