FS#4774 - Extends SPDIF Enable option for Battery / Charger.

Attached to Project: Rockbox
Opened by Anonymous Submitter - Sunday, 05 March 2006, 10:41 GMT
Last edited by Peter D'Hoye (petur) - Thursday, 02 August 2007, 21:13 GMT
Task Type Patches
Category Battery/Charging
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


(against today's CVS).

This patch extends the "Optical Output" option on HAVE_SPDIF_POWER/HAVE_CHARGING platforms (iRivers) from "OFF/ON" to "OFF/Battery Only/Plugged Only/Battery & Plugged". SPDIF switching is then done automatically based on power status changes.

This is useful eg. when always using the optical out at home, but not wanting to draw unnecessary battery power on the move.

It also auto-disables it when USB is connected, and refreshes on disconnection.

The changes only affect HAVE_SPDIF_POWER/HAVE_CHARGING platforms (CONFIG_BLOCK_VERSION is bumped, so write a .cfg file before running).

Seems solid, no known issues.
gl.tter (gl.tter [AT] r-i-l [DOT] net)
This task depends upon

Closed by  Peter D'Hoye (petur)
Thursday, 02 August 2007, 21:13 GMT
Reason for closing:  Rejected
Additional comments about closing:  real name policy!
Comment by gl (gl.tter) - Sunday, 05 March 2006, 10:53 GMT
Here's the patch.
Comment by gl (gl.tter) - Sunday, 05 March 2006, 10:55 GMT
(note I created the task before signing up - hope this doesn't cause any problems).