• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category Utils
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.0
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Fredrik Öhrn - 2006-03-14
Last edited by Maurus Cuelenaere - 2009-12-15

FS#4831 - Change web server mime type for .diff

Files with a .diff extention are sent as octet stream, changing it to text/plain instead makes quick inspection of patches much easier.

Closed by  Maurus Cuelenaere
2009-12-15 11:53
Reason for closing:  Works For Me
Additional comments about closing:  

This seems to be resolved.

Björn Stenberg commented on 2006-03-19 15:26

It doesn't actually set octetstream automatically, it assignes different mime types depending on the contents of the file.

I agree it's an annoying behaviour (excarbated strongly by Firefox' lack of "view in browser") but I currently don't know how to fix it. (Did a quick peek in the flyspray source but couldn't find where it's figuring out the type.)

Fredrik Öhrn commented on 2006-03-19 21:49

OK, I figured it out. Flyspray takes the mime type supplied by the uploading browser and sticks it into the database (scripts/modify.php, line 1175). When someone downloads the file it blindly sends the stored mime type (index.php lines 102-130).

Since most browsers know jack shit about the file they are uploading they play is safe and send application/octet-stream.

It'll require some major surgery ro fix this silly behaviour, I guess I'll just have to go to Flyspray's site and complain loudly…

Fredrik Öhrn commented on 2006-03-19 21:51

Well, associating .diff with text files didn't help, Firefox still uploads them as a binary file.

Peter D'Hoye commented on 2007-08-03 20:40

/me pokes Bjorn

Peter D'Hoye commented on 2008-12-12 18:24

so this is now a battery/charging issue? Great!

Marc Guay commented on 2008-12-12 21:55

Fun! The change was actually from Feature Request to Bug so that it wasn't lost in the sea, and there's no category for Flyspray-related items.

Maurus Cuelenaere commented on 2009-07-27 15:09

Isn't this solved now?

I haven't seen any new diffs with the wrong mime type lately..


Available keyboard shortcuts


Task Details

Task Editing