FS#4832 - Xobox Improvements

Attached to Project: Rockbox
Opened by Max Ried (bot47) - Tuesday, 14 March 2006, 13:52 GMT
Task Type Patches
Category Applications
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


Some Xobox improvements. Better iPod key assigments, a small cheat and a more friendly loading screen.
This task depends upon

Closed by  Mikael Magnusson (mikaelh)
Monday, 29 January 2007, 19:25 GMT
Reason for closing:  Out of Date
Additional comments about closing:  Didn\'t get a fixed version for a year, feel free to resubmit an updated version according to comments and reopen.
Comment by Paul Louden (darkkone) - Tuesday, 14 March 2006, 14:03 GMT
Generally speaking, many plugins use Menu+Select to quit. It's kinda the accepted combination.
Comment by Max Ried (bot47) - Tuesday, 14 March 2006, 14:14 GMT
I know, but this app is an exception. The current quit combination realy hurts the gameplay.
Comment by Paul Louden (darkkone) - Tuesday, 14 March 2006, 14:17 GMT
Since the select button isn't used in gameplay, just to pause, I'm curious how it hurts it?
Comment by Max Ried (bot47) - Tuesday, 14 March 2006, 14:21 GMT
You have to control the position of the worm realy fast. It often happens that you hit action + menu accidetaly at the same time if you just want to make the worm go upwards. That's it.
Comment by Paul Louden (darkkone) - Tuesday, 14 March 2006, 14:24 GMT
So, what's the different with SELECT | PLAY then? I mean, are you just less likely to press it when moving down?
Comment by Max Ried (bot47) - Tuesday, 14 March 2006, 14:25 GMT
Just try it and you WILL notice that my correction is senseful.
Comment by Paul Louden (darkkone) - Tuesday, 14 March 2006, 14:26 GMT
Except I've played the game quite a bit, and have never accidentally hit menu. So, please refrain from telling me I will do something that it is evident I haven't. Since you can move up from the bottom, or down from the top, and since menu is equidistant from select compared to play, what benefit is gained by simply putting the option on the opposite side of the pad?
Comment by Dave Chapman (linuxstb) - Tuesday, 14 March 2006, 14:44 GMT
I also don't understand why MENU+PLAY is any different to MENU+SELECT. It's never given me problems on either my 5g iPod, or my 4g Color.

Other comments about your patch:

a) Don't comment out code - remove it.
b) Don't use TABs (see docs/CONTRIBUTING in cvs)
c) A key combination for CHEAT needs to be defined for all keypad types, not just the iPod.
d) LCD_RGBPACK is only defined for targets with colour LCDs (see firmware/export/lcd.h)

It's always helpful to test-compile patches for a variety of Rockbox targets - at a minimum, one Archos device, one iriver and one iPod, but preferably more.