FS#4961 - Adds Disc Number ID Tag for Tagcache (Feature Request FS#4957)
Opened by Charles Voelger (rotundo) - Thursday, 30 March 2006, 17:32 GMT
Last edited by Dan Everton (safetydan) - Friday, 03 August 2007, 10:13 GMT
|
DetailsThis adds disc numbers to tag cache.
|
Friday, 03 August 2007, 10:13 GMT
Reason for closing: Accepted
Additional comments about closing: Patch committed to SVN. Thanks.
Thanks a lot for your patch !
I've tested on my 4GB Nano and it worked fine, but I haven't tested on anything else (besides the simulator) and I don't guarantee it will work or that it will not cause any troubles.
The default behaviour is to show the tracknumber with discnumber in front of it, but when there is no discnumber tag (or when it is a string instead of a number), it shows one more 0... But at least it is now correctly sorted =)
It worked correctly with Vorbis, MP3 and MPC. I haven't tested anything else, but I think it will work with some other format too.
And if you want to change the syntax of TagCache config file, you can use "discnum" to deal with it.
Lets assume that the disc number tag is AB, where A is the first digit and B is the second digit
1. Read Disc number from ID3 tag, store in variable X
2. If X is greater than 9, display disc number as AB
3. If X is smaller than 10, display disc number as B
Is this automatic, or has this been missed?
Thanks
Andy
Andy, you probably missed the change done in tagnavi.config, there you can see that it's now sorted by disc number first. The change in other files are to make rockbox understand the disc number tag.
I'm having trouble to compile the simulator with this patch, some problem with speex it seems (probably I will have the same error without the patch...), but it compiled fine for iPod Nano.
On an unrelated note, what is required for this patch to be accepted into the 'real' code (and hence provided in the daily builds)?
http://forums.rockbox.org/index.php?topic=8723.0
Andy, I have no idea about what it is required to this patch to be accepted, but I may join #rockbox someday and ask some developer with access to SVN. But for now you need to build your own Rockbox.
Also, does it support getting disc numbers from VORBIS comments?
Cheers
Andy
I created a new patch with WPS_TOKEN_METADATA_DISC instead of WPS_TOKEN_METADATA_TRACK_TITLE.