Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category LCD
  • Assigned To No-one
  • Operating System iAudio X5
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by RaeNye - 2006-05-31

FS#5474 - Brightness & Contrast for the X5

1. Adapted the HAVE_BACKLIGHT_BRIGHTNESS control of the H300 for the X5.
2. Added contrast control via VDV voltage of the LCD (same way that the OF does that).

Also edited settings{.h,.c,_menu.c} as appropriate.

comments for commiter:
a. please get rid of lcd_default_contrast() and replace it by DEFAULT_CONTRAST_SETTING on other platforms as well.
b. maybe it’d be wiser to #define HAVE_LCD_CONTRAST instead of checking !defined(LCD_COLOR) || defined(IAUDIO_X5).

(application/octet-stream)    contrast-brightness-x5.patch (6.3 KiB)
Closed by  RaeNye
2006-07-23 22:18
Reason for closing:  Accepted
RaeNye commented on 2006-06-12 19:18

BillKerr says:

—8←—–8←—–8←—–8←—–8←–

I have managed to get the contrast & brightness patch to work!! The problem is exactly as RaeNye said: the settings need to be reset & rebuilt.
I edited apps/settings.c and changed line 97 from

#define CONFIG_BLOCK_VERSION 44

to

#define CONFIG_BLOCK_VERSION 45

This forced the stored settings to be rebuilt & reloaded. The brightness & contrast changes perfectly now.

—8←—–8←—–8←—–8←—–8←–

ChristianGmeiner commented on 2006-07-18 18:48

I am looking at this patch to get it into CVS.

RaeNye commented on 2006-07-18 23:38

Ready for commit:
- bumped CONFIG_BLOCK_VERSION
- resynced with current CVS - tested compilation on h1xx, h3xx, ipod photo, archos player and x5
- apply with patch -p1

(application/octet-stream)    contrast-brightness-x5.patch (6.8 KiB)
ChristianGmeiner commented on 2006-07-19 07:34

Can you tell me in which datapaper and on with site number i can find the register call?

RaeNye commented on 2006-07-19 14:35

Assuming you refer to the contrast part (the brightness is just modifying PWM rate as done in the H3xx),
the relevant datasheet is the first link in
http://www.rockbox.org/twiki/bin/view/Main/IaudioX5HardwareComponents#LCD_Varitronix_COG_T180MLH page 31 describes POWER_REG_5 (0x0e) and page 34 describes the relevant field (VDV).

The OF sets contrast in the same manner.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing