- Status Closed
- Percent Complete
- Task Type Patches
- Category User Interface → Language
- Assigned To No-one
- Operating System All players
- Severity Medium
- Priority Very Low
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#5766 - Fix for various voice-related crashes
The attached patch updates playback.c so that the required buffers for a voice codec are initialised even if no voice file is loaded, if thumbnail clips are in use. Without this, attempting to use .talk clips without a voice file will crash. See bug FS#5570 for details.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Here’s the patch.
OK, take 2. This will set up the voice codec if a voice file has been loaded or thumbnails are in use.
I keep forgetting to attach the right patch… here it is.
Add the following patch to force a call to audio_set_crossfade when the .talk options are changed. This works a bit better, but still can crash. Unfortunately I don’t have time to look further right now.
Fixed the above problem and it seems to have been caused by the same bug which causes Ogg Vorbis (and maybe other codec) playback crashes. The attached patch supercedes all above attachments.