FS#5969 - Track skip in repeat-1 mode skips the track
Opened by Will Robertson (aliask) - Monday, 11 September 2006, 05:24 GMT
Last edited by Will Robertson (aliask) - Friday, 03 August 2007, 13:48 GMT
|
DetailsPreviously skipping a track in repeat-1 mode would start playback again of the same track.
As dongs pointed out on IRC (repeatedly) from his detailed studies of many people this is unintuitive. So here the fix is. |
Friday, 03 August 2007, 13:48 GMT
Reason for closing: Invalid
Additional comments about closing: Patch completely useless, perhaps this could be opened as a feature request if anyone feels it's necessary. No point leaving the task open.
As you can see, the problem is that the repeat-1 is handled at the playlist level by building a playlist with only 1 track and letting it repeat. This is why it isn't easy to fix this issue.
A possible solution would be to handle the repeat-1 in the playback code instead, so it only calls playlist_next() when actually skipping a track.