FS#6081 - AGC-safety clip: gain INCREASES!

Attached to Project: Rockbox
Opened by Arni (Arni) - Thursday, 28 September 2006, 12:05 GMT
Task Type Bugs
Category Recording
Status Closed
Assigned To No-one
Operating System Iriver H100 series
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


"AGC-safety clip" would fit perfectly for live-music-recordings IF it would NEVER increase the levels but only decrease them for not clipping.
I realized AGC-fast for speech goes down AND up at a decent speed, thats ok.
AGC-safety clip: it goes down, but when i start at gain +5dB and it should be +15dB for recording radio, it goes up to maybe +6 or +7dB after several hours but not to +15dB gain.

Petur said, he experienced the same problem and said that AGC-safety clip should NEVER INCREASE but only DECREASE the gain when clipping occurs.

best regards
This task depends upon

Closed by  Peter D'Hoye (petur)
Sunday, 01 October 2006, 11:45 GMT
Reason for closing:  Fixed
Comment by Peter D'Hoye (petur) - Saturday, 30 September 2006, 23:08 GMT
The current code doesn't prevent gain increase by the AGC in safety mode, and the part of the code responsible for the gain change is (I think) the balance control. It will alter gain if one channel gets below -32dB and the other above (iiuc).
Fix coming as soon as I get the time ;)