FS#6164 - PLAY action executes again on exit from settings_save_config()

Attached to Project: Rockbox
Opened by Stephane Doyon (sdoyon) - Wednesday, 11 October 2006, 01:35 GMT
Last edited by Jonathan Gordon (jdgordon) - Sunday, 22 July 2007, 05:50 GMT
Task Type Bugs
Category Battery/Charging
Status Closed
Assigned To No-one
Operating System All players
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


After saving settings, the release action for the PLAY button is executed
again from the file browser, going to WPS and toggling playback...

I believe this patch should fix this detail.
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 22 July 2007, 05:50 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed a while ago. trying not to reintroduce.
Comment by Stephane Doyon (sdoyon) - Wednesday, 11 October 2006, 01:37 GMT
Woops, here's the attachment
Comment by Jonathan Gordon (jdgordon) - Thursday, 30 November 2006, 14:30 GMT
Right idea, but thats not the best place for it.
signalscreenchange() shhuold only be called in functions which actually have a button loop,
Hopefully the new menu system will be commited soon which will solve this problem.
Comment by Jonathan Gordon (jdgordon) - Tuesday, 26 December 2006, 21:55 GMT
OK, my nano doesnt like pressing play in the vkeyboard, So i dont know if this fixes your problem or not. so, can you replace BUTTON_PLAY with BUTTON_PLAY|BUTTON_REL in apps/keymaps/keymap-ipod.c line 159 and let me know if that fixes it?
Comment by Jonathan Gordon (jdgordon) - Monday, 19 February 2007, 07:02 GMT
just checking if this is still an issue?