Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Music playback
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Reza - 2006-10-20
Last edited by Peter D'Hoye - 2007-06-24

FS#6213 - Audioscrobbler incorrectly submits last song

This is very easy to reproduce. Listen to a song; do not go past the 50% point (listen for a few seconds or so). Now, while playing, turn off the player (in my case the iAudio X5). This also works even if you stop music playback then turn off(hold play/pause for a few seconds on the X5). When you submit the .log file, it counts this song as played even though you didn’t go past the 50% point. I use LogScrobbler 0.8 to submit my songs BTW.

Closed by  Peter D'Hoye
2007-06-24 18:46
Reason for closing:  Accepted
Additional comments about closing:  

Thank you ;)

Robert Keevil commented on 2006-10-20 20:10

Because playback hasn’t advanced to the next track, scrobbler.c is using the previous tracks elapsed value.

Attached patch fixes it for me on ipod (where direct shutdown isn’t possible - since stop and shutdown share the same button). Does this work when the player is turned straight off?

Robert Keevil commented on 2006-10-30 21:38

This should fix the issue on devices with off buttons. Tested on ipod after enabling the Shutdown option in the main menu.

Can you test this attached patch?

Admin
Linus Nielsen Feltzing commented on 2007-01-22 13:27

Does anybody know if this patch solves the problem for all players? I want to commit it.

Robert Keevil commented on 2007-02-11 22:17

Re-sync’d and re-tested, on a 5g. I can’t see why it would be different on any other SWCODEC target. Needs testing on a HWCODEC device, but last.fm logging is currently broken for Archos targets ( FS#6639 ).

Robert Keevil commented on 2007-05-05 10:06

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing