Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Medium
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by rbx-multiplex - 2006-10-21

FS#6223 - Make %rg tag show the RG type actually in use

A discussion in the forms (http://forums.rockbox.org/index.php?topic=6979.0) suggested that the %rg tag should actually show what Replay Gain is in use - not what the setting is so that is what this patch does.

So if you have “track gain if shuffled” the value returned changes between 2 & 3 depending on the shuffle type, also shows none if a setting is applied but there are no tags.

There will be a false return value of None if the desired RG tag has the value of zero - but that is unlikely I think, and the effect is the same a no tag anyway.
Change is in gwps-common.c

   rg_patch (1.3 KiB)
Closed by  mmmm-
2006-11-15 18:41
Reason for closing:  Accepted

Updated patch to return; off, Track, Album, ShuffleTrack, ShuffleAlbum, or NoTag. So all eventualities are covered.
%?rg<off|Track|Album|ShuffleTrack|ShuffleAlbum|NoTag>
and %rg returns the string version of the Gain in use or 0.0dB

   rg_patch (3.6 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing