Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Settings
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Stephane Doyon - 2006-10-25
Last edited by Nils Wallménius - 2007-08-06

FS#6236 - talk mp3 clip fallback

When the talk_dir setting is set to talk mp3 clip, but no _dirname.talk
file is found for a directory, dirbrowse() falls back to saying the
directory’s number. I don’t find that particularly useful, and I’d much
rather it spelled it instead.

I’m probably not the only one who thinks this way, because that’s
currently what’s done for files. (There’s a confused comment that says /*
spell the number as fallback */).

This patch (dot_talk-fallback-spell.diff) replaces the talk mp3 clip
option with two options: talk mp3 clip fallback numbers, and fallback
spell. That for each of talk_file and talk_dir.

Closed by  Nils Wallménius
2007-08-06 16:15
Reason for closing:  Out of Date
Additional comments about closing:  

Something similar was committed a while ago

Stephane Doyon commented on 2006-10-25 05:27

Oops, glitch. Somehow I missed the increase in the settings’ storage
size from 2 to 3 bits.
Here’s a corrected patch.

Jens Arnold commented on 2006-10-26 18:48

I think it would be better to split the file & directory into 2 separate settings. One for selecting the preferred method if no talk clip is present, and a second one whether talk clips should be used if present.

Stephane Doyon commented on 2006-10-26 23:51

Hmmm that’s an idea. It seems cleaner. OTOH in increases a lot the number
of options to check out under the voice menu…

Still. I’ll try it. No time until next week though.

Hmm that way we can add as a seperate option whether or not to say the
file type (currently done only for the number option, which is lame).

I have to wonder whether anyone really uses the numbers option
though. Perhaps in some special circumstance it might be useful, if you
have lots of ordered files with a long common prefix… And does anyone
really choose a different method for files vs directories? Anyway I
prefer to keep existing functionality so I’m not proposing to remove that
distinction, but I’m stil wondering.

Steve Bavin commented on 2006-10-27 05:35

I use the numbers option for files and spelling or .talk clips for folders, so don’t go removing them, or the ability to select seperately! ;)

I agree with amiconn. We just need a none/spell/numbers selection for file and directory, then a seperate option to use the .talk clips if present.

Jens Arnold commented on 2006-10-27 06:32

I also use the numbers option for files and .talk clips for folders.

Spelling is nice, but for my taste it is far too slow for regular use, and having .talk clips for all files is too much clutter imo. The file type is what I am mainly interested in for files.

Back when the voice feature was added in 2004, I also suggested adding an option to say the file type in spelling mode instead of spelling the file extension. The argument against it was that the style mix would be confusing.

Stephane Doyon commented on 2006-10-31 03:02

About speaking the file type when spelling: replacing the extension isn’t
all that useful IMHO because the extension says it all and is more
specific (as in .ogg instead of just “audio”). But speaking the file type
BEFORE spelling would be a plus IMHO: spelling is slow, and you have to
wait until the end to find out the type, especially annoying if you’re
looking for a bookmark file.

About .talk files being a lot of clutter: I find that too, although I
find them useful enough to endure it. Would it help if the .talk clip
files had a dot prepended? Then on UNIX at least they wouldn’t show up in
an ls output. Disadvantages though: you can’t see easily which file has a
.talk, and they’re at the beginning of the listing when they’re not
hidden. Alternatively we could perhaps bundle all the .talk files for a
directory into one big blob file somehow. That’s a project for another
day though :-).

Stephane Doyon commented on 2006-10-31 03:09

OK, here’s a new patch with the settings split as requested, and an
additional setting for filetype.

So there’s a setting for off / number / spell, and another to use .talk
clips if present. And you have each of these two settings for each of
directories and files.

An additional setting enables speaking the file type when saying numbers
or spelling. When spelling the file type is spoken BEFORE spelling. This
option also causes it to say “folder” after playing a directory’s .talk
clip.

Is that better?

Stephane Doyon commented on 2006-11-02 23:51

Another version with a slight correction: I noticed that
LANG_VOICE_DIR_HOVER is not only used in the settings menu, it’s also
spoken when announcing .talk files, so I can’t deprecate it.

Stephane Doyon commented on 2006-11-13 03:11

Fix a little talk enqueue glitch when no filetype is available for a file.
Make it just a bit prettier too.

Admin
Linus Nielsen Feltzing commented on 2006-11-13 09:24

You can’t change the ID name in english.lang without changing all the other languages as well.

- id: LANG_VOICE_DIR
+ id: LANG_VOICE_DIR_SPEAK

Otherwise you will break all other translations.

Stephane Doyon commented on 2006-11-13 20:20

Err indeed. Ouch. Many thanks for reviewing and pointing this
out. Here’s a revised version with no renamed id:.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing