FS#6319 - implemeent the button changes agreed on the dev ml for the setting screen

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Sunday, 12 November 2006, 00:48 GMT
Last edited by Jonathan Gordon (jdgordon) - Sunday, 10 June 2007, 04:09 GMT
Task Type Patches
Category Settings
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


this adds the checkmark option and changes the keys to
> UP/DOWN selects items
> LEFT exits no change
> RIGHT applies and exits
> NAVI (a.k.a. select) makes change but does not exit dir
> OFF exits, cancels any changes

no change on the player.

this needs to be tested on the actual targets for button correctness...
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 10 June 2007, 04:09 GMT
Reason for closing:  Out of Date
Comment by Jonathan Gordon (jdgordon) - Sunday, 12 November 2006, 02:33 GMT
added iriver remote keymaps, other targets with remotes need adding..

tested and working on iriver hxxx and ipod
Comment by Bryn Smith (thePianoMan) - Sunday, 12 November 2006, 05:50 GMT
Very nice, works well on my 5G iPod... just wondering if you're still planning on implementing the "show moved tick for a second" when you press the right arrow to apply and exit... that didn't seem to be present.

But it is nice and easy to use! Well done! :)
Comment by Jonathan Gordon (jdgordon) - Sunday, 12 November 2006, 05:55 GMT
"show moved tick for a second" - i forgot all about that actually.. i could put a half second pause there but i dont really think thats nessaccery...

just waiting for an ok for the buttons on the x5, all archos, h10, e200 and ifp targets
Comment by Barry Wardell (barrywardell) - Sunday, 12 November 2006, 12:13 GMT
Works very well on my H10. Buttons for the e200 look OK, but can't really be tested properly yet.

I did a bit of experimenting and found that showing the moved tick for 1/10 of a second worked well. It gives visual confirmation without slowing down the UI.
Comment by Rani Hod (RaeNye) - Monday, 13 November 2006, 17:19 GMT
Works OK on X5 (main only, remoted untested). I just love the new intuitive way it works!

One glitch I happened to find in LCD settings:
when selecting LCD mode->inverse with SELECT, everything is OK (i.e., LCD is inverted as it should);
when selecting it via RIGHT, nothing happens until the next time you enter LCD mode and only then the inversion is applied.
Comment by Marianne Arnold (pixelma) - Tuesday, 14 November 2006, 18:51 GMT
I tried on my OndioFM today to be able to give constructive critics...

First of all it doesn't work properly on my device - I expected that I could use "Mode" as select button but nothing happened (tried with sound settings where I also could hear if it did). Then I thought that at least "right" as select and exit would work but it had a strange effect (at least in the bass settings) - when I selected something with "right" it exited the menu as expected but there was no noticable change. When I reentered this setting's menu it suddenly changed (to what I've chosen before) and the tick was at the right place (same what RaeNye described).

Second and more important: I dislike this way of setting very much as it doesn't update live. So if I try to adjust bass or trebble (or...) it would need an additional unnecessary button press and the procedure would take significantly longer. It would be: moving to the next item, then select, then listening if the setting is ok now... probably not, then move to the next and so on (worst case I could imagine is adjusting volume through the Audio Playback menu in Sudoku). If settings change "live" as they do now I can "monitor" my changes, stop and apply the one I want. And I think that it is even easier for a newbie if he/she can find out what a specific setting will do while browsing. So please think (talk) this over again!