FS#6388 - Pitch as a setting

Attached to Project: Rockbox
Opened by Stephane Doyon (sdoyon) - Tuesday, 28 November 2006, 02:51 GMT
Last edited by Jonathan Gordon (jdgordon) - Sunday, 05 August 2007, 13:26 GMT
Task Type Patches
Category Music playback
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Is there any reason why the pitch value isn't saved along with other

I would like it to persist across reboots, and possibly to be able to set
it through a config file.

Here's a patch, seems to work for me but it would need review.
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 05 August 2007, 13:26 GMT
Reason for closing:  Out of Date
Additional comments about closing:  patch very out of date.. if someone really wants this a new patch is needed
Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 28 November 2006, 08:45 GMT
The pitch is not saved because it is considered temporary, and not something people in general would want to have persistent. That is because the original idea was to use the pitch for DJ mixing. However, if there is a general need for it to be saved, we could of course apply this patch.
Comment by Stephane Doyon (sdoyon) - Tuesday, 28 November 2006, 14:40 GMT
Well my use for pitch is to play audio books faster. Also useful for
podcasts. Long time audio book readers develop this ability to understand
fast speech, up to maybe 2times when concentrating and in quiet
surroundings. Reading outloud is relatively slow :-). Blind readers have
gotten used to speeding it up because we've had those specialized
cassette players with adjustable speed available for over 25years. And
when you're actually working with an audio book (as opposed to just
relaxing) then there's a productivity angle.

Later specialized cassette player models (since maybe 15years) also offer
a function to compensate the pitch transpose that occurs when speeding up
playback. Nowadays the digital Daisy players do that in software. That's
like sox's pitch effect I believe: speed up playback but keep the pitch
the same. (Some voicemail services offer that too...) That's a capability
I would dearly like to see added to RB, because high-pitched speech is
less intelligible and somewhat annoying, and I intend to look into
integrating some code for that some day, but that's another story.

Anyway the point was that it's much nicer to have the pitch as a
persistent setting, so that when you turn your player back on and resume
playing your audio book, it continues at the speed you had it when you
shut it off.
Comment by Nils Wallménius (nls) - Tuesday, 28 November 2006, 21:00 GMT
Here's a (rather heated) discussion on the matter (speed/pitch thing)  FS#5668 
Comment by Paul Louden (darkkone) - Thursday, 30 November 2006, 03:05 GMT
Here's my opinion on the matter:

Pitch, adjusted from the Sound Settings Menu, should be treated as permanent. Pitch from the pitch quickscreen should be treated as temporary.

If you only want to change it once, ever, going to a static screen for it isn't so much a cost, whereas that way it doesn't become permanent for those used to adjusting it temporarily anyway.
Comment by Alexander Levin (fml2) - Sunday, 03 December 2006, 19:49 GMT
Paul, I like your idea very much! If it should be done then this way!