FS#6505 - Slider progressbar

Attached to Project: Rockbox
Opened by Nicolas Pennequin (nicolas_p) - Thursday, 04 January 2007, 17:30 GMT
Last edited by Paul Louden (Llorean) - Wednesday, 16 January 2008, 14:16 GMT
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No


This patch adds the %S|filename.bmp| WPS tag to allow displaying a slider bitmap instead of the regular progressbar.
It works exactly like %P|filename.bmp| (bitmap progressbar), but instead of displaying just a part of the specified bitmap, it will display it entirely at the right place to show the progress. was the inspiration for this quick patch.
This task depends upon

Closed by  Paul Louden (Llorean)
Wednesday, 16 January 2008, 14:16 GMT
Reason for closing:  Duplicate
Additional comments about closing:  %px should cover this functionality in a much more flexible way.
Comment by Nicolas Pennequin (nicolas_p) - Friday, 05 January 2007, 14:27 GMT
(forget this)
Comment by Norbert Preining (norbusan) - Friday, 05 January 2007, 17:14 GMT
Included in my build:
Thanks Nicolas!
Comment by Eddy (bascule) - Sunday, 04 February 2007, 08:43 GMT
While listening to a 146MB, 64kbps, 32000hz, 5:19:00(roughly) file the slider progressbar disappeared at the 3:36:00 -- 3:37:00 mark. It would stay gone until the end of the file. When the next file played it would appear again.
Tried with another different file(almost exact same attributes as above) and same thing occured.

I have a Gigabeat F20, Jan 27th build. No other patches applied. Custom theme(my own), BMP heavy. If any other info is required just ask.

I'd appreciate it if someone else tried to recreate this bug as well to collaborate with my own account.

Thank you & special thanks to the developer of this patch, I really dig this patch
Comment by Flake (Flake) - Friday, 09 February 2007, 23:21 GMT
does it work with old style progress bar also?
Comment by Nicolas Pennequin (nicolas_p) - Sunday, 11 February 2007, 21:41 GMT
Flake: No, it doesn't. That would be a different thing to implement in the code.
Comment by Nicolas Pennequin (nicolas_p) - Monday, 12 February 2007, 21:28 GMT
Here is another version that *should* solve the problem described above.
Comment by Nicolas Pennequin (nicolas_p) - Saturday, 17 February 2007, 17:55 GMT
Previous version didn't solve the problem. This one does.
Comment by Frank Grisafi (JobVanDam) - Tuesday, 06 March 2007, 20:42 GMT
Ah jeez.... Sorry Nic but I think I found a bug, maybe.
I have a Gigabeat F20, Build is March 4.

The Progress Bar goes slightly past the point where I defined it to stop.
I remember the old version didn't go this far cause I explictly remember making the point where it stops one pixel less cause that was the way I wanted it.
Comment by Frank Grisafi (JobVanDam) - Tuesday, 06 March 2007, 20:44 GMT
Forgot to add...
If you don't feel like fixing this I'll totally understand and still want to thank you for making this nifty patch.
Comment by Hepdog (007quick) - Wednesday, 04 April 2007, 19:55 GMT
Needs A sync
Comment by Max Weninger (maxwen) - Monday, 30 April 2007, 17:33 GMT
Comment by Max Weninger (maxwen) - Monday, 30 April 2007, 17:37 GMT
Comment by Frank Grisafi (JobVanDam) - Wednesday, 16 May 2007, 00:11 GMT
I just had to say a big fat thank you to Nic for making the patch and Max for syncing it. Now it's absolute perfection needs no correction.
Comment by Max Weninger (maxwen) - Friday, 22 June 2007, 13:46 GMT
Comment by Frank Grisafi (JobVanDam) - Friday, 16 November 2007, 12:56 GMT
Needs another sync please. Started failing on the 11th of November.
Also if you want to fix it there's a bug where if the time goes past 3:33:33 the graphic for the progressbar disappears. After about 5 hours it starts to appear on the left of the screen.
Comment by Eddy (bascule) - Friday, 16 November 2007, 20:04 GMT
To be honest, i think this task could be closed now, as the recent-ish change to the progressbar to allow conditionals ( allows this same functionality.

Comment by Frank Grisafi (JobVanDam) - Friday, 16 November 2007, 21:30 GMT
The song percentage tag does have it's strengths (ie. vertical progress, curved progress) but because you have to plot the path of the progress it will never be as smooth as this patch. Also if you did try to replicate this patch with the tag it's possible you may run out of letters to use for the conditional.

With this patch you simply state start from point A and stop at point B.