Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System Iriver H100 series
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by mlind - 2007-01-06
Last edited by jdgordon - 2008-08-10

FS#6512 - Make plugin Disktidy avoid opening too many dirs

The patch makes plugin Disktidy avoid going too deep into nested subfolders.
Due to a recursive function there was a possibility that the plugin tried to open more directories than the maximum 8 allowed.

The patch is only tried on an iRiver H120.

The patch is still in my experimental version and stops and waits for keypress RIGHT if open directories exceed 5.
This was to be able to see what happened.
Also I added line wrapping of the displayed path.

Haven’t checked what else has to be done according to RockBox standards

(application/octet-stream)    disktidy.nestedsubfolders.pat... (3 KiB)
Closed by  jdgordon
2008-08-10 12:53
Reason for closing:  Out of Date
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

no longer needed

darkkone commented on 2007-01-06 21:27

Does it provide an error splash if it can’t clean everything?

mlind commented on 2007-01-06 22:58

Hm. Not yet.

darkkone commented on 2007-01-06 23:00

It exits out with an error for a reason: That it cannot complete.

If it’s going to continue, it should at least make it very, very clear to the user that the operation was not completed successfully.

mlind commented on 2007-01-07 00:11

Here’s a better one.

Only stops to show what dir it skips - and tells user to push PLAY/SELECT to continue.
When Disktidy is done there first comes a splash that says how many items were deleted, and then another one that says how many dirs it skipped.

(application/octet-stream)    disktidy.nestedsubfolders2.pa... (11.2 KiB)
mlind commented on 2007-01-07 00:16

I don’t see how I can edit my first post!?!?
It seems like a better idea to put the latest patch there…

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing