FS#6743 - Play button in playlist viewer should go to WPS

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Tuesday, 06 March 2007, 12:43 GMT
Last edited by Steve Bavin (pondlife) - Sunday, 12 August 2007, 16:02 GMT
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


The PLAY button does nothing in the playlist viewer. It would be better if it went to WPS.
This task depends upon

Closed by  Steve Bavin (pondlife)
Sunday, 12 August 2007, 16:02 GMT
Reason for closing:  Out of Date
Comment by Shachar (Lamed) - Saturday, 14 April 2007, 21:48 GMT
Peter... You've made it go into the last playlist menu, not the wps.
Comment by Peter D'Hoye (petur) - Tuesday, 01 May 2007, 21:26 GMT
bah... closing a task doesn't add you to notificationslist when it gets re-opened :(

will have a look what you mean...
Comment by Peter D'Hoye (petur) - Tuesday, 01 May 2007, 21:29 GMT
err... it _does_ switch back to WPS on my H380,
on what target do you see it fail?
Comment by Shachar (Lamed) - Friday, 11 May 2007, 10:07 GMT
on the 11.5.07, it takes you back from the playlist viewer screen to the playlist menu. imho just like in most menus, the play button should go directly to the WPS. you already have the back and left buttons to go back one level.
btw, if you go 'manage settings' -> 'browse .cfg files' then you get the same behavior: first Play (on) click takes you back to 'manage settings' menu, then the next click takes you to the wps screen.
Comment by Peter D'Hoye (petur) - Friday, 11 May 2007, 12:27 GMT
Well, as I stated in my comment right above yours: on my h380, pressing PLAY in the playlist viewer *does* take me to the WPS, not the previous menu.
Same for manage settings: pressing play also brings up the WPS.

What player do you see this behaviour on? It works perfectly OK on mine....
Comment by Shachar (Lamed) - Saturday, 12 May 2007, 22:29 GMT
Sorry for not taking a plunge into the code, I'm rather busy for a long while :)
Comment by Steve Bavin (pondlife) - Wednesday, 16 May 2007, 11:12 GMT
Might this be related to  FS#7176  in some way? PLAY from the playlist viewer is working for me btw, but it seems something odd is going on..
Comment by Peter D'Hoye (petur) - Sunday, 27 May 2007, 18:14 GMT
well I still stand by the 'works for me' closing of this task. I also have an h340 btw...

Lamed, please reset your settings and let me know if this still isn working for you, because I about to close this one again.
Comment by Shachar (Lamed) - Tuesday, 29 May 2007, 01:12 GMT
Still, When I view the playlist it firstly goes from the playlist viewer to the playlist menu, and then if I click the play (on) button again - then it goes to the WPS. 05.28. build, reset settings.

By a _very_ quick look, I think playlist_viewer.c:622 shows that the playlist viewr screen just takes you back to the last screen like pressing 'cancel'. I might be wrong, but I'll have time working on this on this week.