Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Medium
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Richard Hoyle - 2007-03-14
Last edited by Nicolas Pennequin - 2007-11-18

FS#6827 - Pictures disappearing under text

Hi,

A change made on 4th/5th March to apps/gui/gwps-common.c has broken a
theme I use on the H3x0.

In my theme’s wps file, I have a text field that does this:

%ar%?rr<0|1|2|3|4|5|6|7|8|9>

I have two conditional graphics below this of the form:
%?fc<%xdb|%xdc|%xdd||%xde|%xdf|%xdg|%xdh|%xdi|%xdj>
%?fv<%xdl|%xdm>

These graphics display for a fraction of a second a the beginning
of a track, then disappear.

The changes made to gwps-common.c are as follows:

@@ -922,11 +922,12 @@

           switch(tag[1])
           {
               case 'p':  /* Playcount */

- *flags |= WPS_REFRESH_STATIC;
+ *flags |= WPS_REFRESH_DYNAMIC;
+ *intval = cid3→playcount+1;

                   snprintf(buf, buf_size, "%ld", cid3->playcount);
                   return buf;
               case 'r':  /* Rating */

- *flags |= WPS_REFRESH_STATIC;
+ *flags |= WPS_REFRESH_DYNAMIC;

  • intval = cid3→rating+1;

snprintf(buf, buf_size, “%d”, cid3→rating);

                   return buf;

###

Rolling back to the pre-patched gwps-common.c, without the changes
above, fixes the problem. I have two themes like this which are
broken in this way.

Thanks for Rockbox.

===Rich

Closed by  Nicolas Pennequin
2007-11-18 13:53
Reason for closing:  Duplicate
Additional comments about closing:  

 FS#6056 

Jonathan Gordon commented on 2007-04-05 13:50

is this still a problem with the new wps code?

Nicolas Pennequin commented on 2007-04-11 17:21

I think the problem simply is that the reporter has graphics displayed under texts. After the change, the text was made to update more often than the graphics (rr becomes dynamic whereas fc and fv are static), so the graphics disappear when the line is cleared to update the text. This is a more general bug with pictures in the WPS code.

Nicolas Pennequin commented on 2007-11-18 13:53

Solution: put the conditionals on the same line as the %?rr conditional:

%ar%?rr<0|1|2|3|4|5|6|7|8|9>%?fc<%xdb|%xdc|%xdd||%xde|%xdf|%xdg|%xdh|%xdi|%xdj>%?fv<%xdl|%xdm>

That way, they’ll be updated just as often as the %?rr conditional, which will make them stop disappearing.

I’m closing this as a dupe of  FS#6056 , which is basically the same “static vs. dynamic” issue.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing