Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Gerritt Gonzales - 2007-05-05
Last edited by Thomas Martitz - 2011-06-05

FS#7114 - HTML_Parser. Creates a txt file readable in the viewer.

I have only tested this on the sansa.
The txt file created is in the same dir (name.txt),
and is very readable with the text viewer.
All tags are striped as well as extra blank spaces
and newlines are limited.
More formatting to come.
Do not forget to add the file name to SOURCES
and add to viewers.config
html,veiwers/HTML_Parser,0
htm,veiwers/HTML_Parser,0
with the icon number of your choice.
GRaTT

Closed by  Thomas Martitz
2011-06-05 11:40
Reason for closing:  Out of Date
Additional comments about closing:  

There doesn't seem to be interest in this anymore. Open a new task if this is wrong.

Hepdog commented on 2007-05-06 22:56

Might I suggest you do those things for us. If you want stuff like this to be commited you need to make it as easy as possible to do. I would suggest that you just pick an icon for now, or have no icon.

Gerritt Gonzales commented on 2007-05-07 16:46

OK Done. This will patch against current SVN.
TODO additional formatting. It is almost not
required on these small screens.

GRaTT

Gerritt Gonzales commented on 2007-05-07 22:15

Added: formatting on <P> and <BR> tags.
Looks much better now.
Added: support for nested tags, it cleans up some stuff.
A bad HTML page will give a bad conversion.
If a closing > is missed then all the following text will
be discarded.

patch -p0 < HTML_ParserV1.1.diff
Nothing additional required.
GRaTT

Gerritt Gonzales commented on 2007-05-07 22:16

And here is the file

Gerritt Gonzales commented on 2007-08-04 20:19

minor update
When the parser exits the created text file is highlighted
in the directory view.
GRaTT

Gerritt Gonzales commented on 2007-08-04 20:27

one more minor update
added 2 to the filetypes array for htm and html
GRaTT

Gerritt Gonzales commented on 2007-08-06 20:24

updated for changes to plugin directories.
Use of CATALOG file and adds htm and html fyle types.
increase file type array by two (2).
GRaTT

Gerritt Gonzales commented on 2007-08-06 20:29

Above was supposed to say
Use of CATAGORIES file

Gerritt Gonzales commented on 2007-08-08 08:52

fixes a hang if plugin run as a plugin and not a viewer.
GRaTT

Jack Suter commented on 2007-08-11 13:23

I know you want to advertise your other patches, but I already have the calendar patch :P

Here’s a copy without part of the calendar patch:

Gerritt Gonzales commented on 2007-08-11 23:18

Once again thanks jack.
I was heading out of town and trying to get a few things done.
I was not trying to force another patch on anyone.
GRaTT

Jack Suter commented on 2007-08-14 22:01

I know, I sometimes make mistakes when I start to get rushed too =) (j/k about you trying to advertise your other patches)

-Jack

Gerritt Gonzales commented on 2007-08-20 14:35

Removed changes to filetypes.c as no longer needed.
I tried to open the text viewer automatically with the
created text file by adding the function plugin_load()
to plugin.(c/h). It worked great to open and use but on
exit of the text viewer I allways got an undef instruction.
Anybody know of a way to successfully open and close a plugin
from a plugin??
GRaTT

Thomas Martitz commented on 2008-05-18 00:48

Sync and some clean up.

Also, make sure that the trailing ‘\0’ of your header/footer strings doesn’t go into the text file, all text editor I tried (I tried some 7-8) had problems.

I also did some simplification: replace snprintf with strcpy (I wonder why you used snprintf in the first place). Also, there’s no need to rb→write every single byte in a loop, just write all at once. Removed some uneeded variables.

Thomas Martitz commented on 2008-05-18 02:55

Fix red :/

Even though the simulator worked just fine, there was a weird error while compiling a test build.

hitesh mantrala commented on 2009-04-03 22:27

cant get that compiled :(

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing