FS#7251 : Remove unused struct members from the mp3entry struct and rearrange structs to save codesize.

Status Closed
Percent Complete
100%
Task Type Patches
Category Music playback
Assigned To No-one
Operating System All players
Severity Low
Priority Very Low
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by nls - 2007-06-01
Last edited by nls - 2007-10-25

FS#7251 - Remove unused struct members from the mp3entry struct and rearrange structs to save codesize.

This is a reworked version of the changes committed in revision 13527 which were later reverted because of a negative impact on binary size.

In this version I have rearranged the mp3entry struct and the track_info struct (in which the mp3entry struct is a member) this patch now decreases binary size.

Recorder v1 -256 bytes
iriver H300 -48 bytes
ipod video +4 bytes

I also bumped the codec api version as Lear pointed out that changes to these structs could break the api compatiblity. I added info about this to comments before each struct.

mp3entry_struct.diff (6.7 KiB)

Closed by nls
2007-10-25 21:50
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

comitted relevant stuff no reordering