FS#7873 - New keymap for e200's text editor

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Sunday, 30 September 2007, 18:20 GMT
Last edited by Alex Parker (BigBambi) - Sunday, 06 June 2010, 08:28 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System Sansa e200
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


This (my second) patch changes the keymap of the e200 to a more natural and easier to use one.

Editor plugin:
Remove removing a line with context-menu-button
swap the function of power button and left button

Keyboard typing screen
up/down/left/right for browsing in the characters
scrollwheel to move the cursor
rec+up to finish editting the line
rec+down = backspace

I find this much easier to use

Suggestions are welcome, since I can imagine, that it can be optimized even more
This task depends upon

Closed by  Alex Parker (BigBambi)
Sunday, 06 June 2010, 08:28 GMT
Reason for closing:  Rejected
Comment by Thomas Martitz (kugel.) - Monday, 01 October 2007, 13:39 GMT
Small update, should improve the rec+up/down behavior.
Comment by Thomas Martitz (kugel.) - Saturday, 27 October 2007, 23:08 GMT
Updated the patch, so that the swap of power and left button doesn't hit other targets.

Also, got rid of the rec+up/rec+down: Backspace is REC now and Accept/Done is Hold Select.
Comment by Thomas Martitz (kugel.) - Saturday, 03 November 2007, 23:18 GMT
Little bug fix.
Comment by Thomas Martitz (kugel.) - Monday, 19 November 2007, 21:47 GMT
New version:
* The feature to delete on line via hotkey returned, it's hold select as in the SVN
* In the SVN, the "Do what" menu moved to button_down, I changed it to be button_power. Note: I needed to hack a but, since there is no standard action for the power button. I created an action ACTION_STD_POWER_BUTTON_PRESS, which has no use, except making the button usable in the text editor.
* I changed the button_left function to only cancel editing (aka ignore changes and exit), but it shows a splash when there were unsaved changes
* I mapped the "line options" menu to button_down.

Note2: I planned to map the delete line via hotkey feature to the rec_button, but I didn't implement, since it conflicts with another patch I use. However, if you liked it I'd implement it.

Just a question: I know this patch isn't done in a proper way, which is mainly a result of the text_editor using standard context. But is there any chance for a commit, even if only the keyboard screen changes would get committed?

Comment by Mike Kasberg (digerati1338) - Thursday, 03 January 2008, 18:01 GMT
I would also like to know if there's any chance of this patch getting committed. It really does make more sense this way. Having to use left/right buttons and then the scrollwheel to select characters doesn't feel right.
Comment by Thomas Martitz (kugel.) - Saturday, 05 January 2008, 22:03 GMT
Well, v4 isn't working. The reason I didn't notice is that I'm using the real v4 (attached as v5), the v4 I uploaded was the wrong file. Weird but here you go.
Comment by David Maliniak (major_works) - Thursday, 10 January 2008, 21:27 GMT
Needs syncing with commit of FS #8341.
Comment by Thomas Martitz (kugel.) - Thursday, 10 January 2008, 21:39 GMT
Comment by Robin Bertram (berti) - Sunday, 18 January 2009, 16:13 GMT
synced to r19789

just a question: is the "dirty hack" preventing this from being committed?
Comment by Thomas Martitz (kugel.) - Sunday, 18 January 2009, 17:08 GMT
I don't remember that it was up for a discussion.
But there's no way for this patch to get in SVN in its current form, it's too hackish and dirty and stuff. Ideally, the text editor should not use standard button context, but define his own, so things can be more flexible on a per-target basis.
Comment by Robin Bertram (berti) - Sunday, 18 January 2009, 18:35 GMT
ok, that's just what i guessed

so at first text editor must get his own button context
(perhaps I will compare the text editor to plugins that do use their own button context)

and then we can discuss, whether the new behaviour for e200 is wanted or not
Comment by Thomas Martitz (kugel.) - Sunday, 25 January 2009, 20:12 GMT
I think the text editor keymap is fine as of now. However I'd still like to have the keyboard screen changes. maybe I'll figure something good out later.
Comment by Robin Bertram (berti) - Wednesday, 11 March 2009, 18:07 GMT

perhaps i'm the only one using this patch... well... I like it